ソースを参照

adjust factory

itizawa 4 年 前
コミット
f1f580bf91

+ 4 - 3
packages/slackbot-proxy/src/controllers/growi-to-slack.ts

@@ -166,9 +166,10 @@ export class GrowiToSlackCtrl {
 
   injectGrowiUri(req:GrowiReq, growiUri:string):WebAPICallOptions {
 
-
-    const growiUriInjector = GrowiUriInjectorFactory.getDelegator(DelegatorType.MODAL);
-    growiUriInjector.inject(req.body, growiUri);
+    Object.values(DelegatorType).forEach((type) => {
+      const growiUriInjector = GrowiUriInjectorFactory.getDelegator(type);
+      growiUriInjector.inject(req.body, growiUri);
+    });
 
     const opt = req.body;
     opt.headers = req.headers;

+ 1 - 18
packages/slackbot-proxy/src/services/growi-uri-injector/index.ts

@@ -1,10 +1,7 @@
-import loggerFactory from '~/utils/logger';
 import { GrowiUriInjector } from './GrowiUriInjector';
 import { GrowiUriInjectionModalDelegator } from './GrowiUriInjectionModalDelegator';
 import { GrowiUriInjectionButtonDelegator } from './GrowiUriInjectionButtonDelegator';
 
-const logger = loggerFactory('growi-uri-injector:growiUriInjectorFactory');
-
 export const DelegatorType = {
   MODAL: 'modal',
   BUTTON: 'button',
@@ -22,22 +19,8 @@ const TypeToDelegatorMappings:{[key in DelegatorType]:GrowiUriInjector} = {
  */
 class GrowiUriInjectorFactory {
 
-  delegator: GrowiUriInjector;
-
-  initializeDelegator(type:DelegatorType) {
-
-    this.delegator = TypeToDelegatorMappings[type];
-
-    if (this.delegator == null) {
-      logger.warn('Failed to initialize GrowiUriInjector delegator.');
-    }
-  }
-
   getDelegator(type:DelegatorType) {
-    if (this.delegator == null) {
-      this.initializeDelegator(type);
-    }
-    return this.delegator;
+    return TypeToDelegatorMappings[type];
   }
 
 }