adjust type

packages/slackbot-proxy/src/controllers/growi-to-slack.ts

@@ -18,7 +18,7 @@ import { OrderRepository } from '~/repositories/order';
 
 import { InstallerService } from '~/services/InstallerService';
 import loggerFactory from '~/utils/logger';
-import { factory as GrowiUriInjectorFactory } from '~/services/growi-uri-injector';
+import { DelegatorType, factory as GrowiUriInjectorFactory } from '~/services/growi-uri-injector';
 
 
 const logger = loggerFactory('slackbot-proxy:controllers:growi-to-slack');
@@ -166,7 +166,8 @@ export class GrowiToSlackCtrl {
 
   injectGrowiUri(req:GrowiReq, growiUri:string):WebAPICallOptions {
 
-    const growiUriInjector = GrowiUriInjectorFactory.getDelegator('MODAL');
+
+    const growiUriInjector = GrowiUriInjectorFactory.getDelegator(DelegatorType.MODAL);
     growiUriInjector.inject(req.body, growiUri);
 
     const opt = req.body;

packages/slackbot-proxy/src/services/growi-uri-injector/GrowiUriInjectionModalDelegator.ts

@@ -1,15 +1,15 @@
+/* eslint-disable @typescript-eslint/explicit-module-boundary-types */
 import { GrowiUriInjector } from './GrowiUriInjector';
 
 export class GrowiUriInjectionModalDelegator implements GrowiUriInjector {
 
 
-  inject(body: any, growiUri:string): any {
+  inject(body: any, growiUri:string): void {
     if (body.view != null) {
       const parsedView = JSON.parse(body.view as string);
       parsedView.private_metadata = JSON.stringify({ growiUri });
       body.view = JSON.stringify(parsedView);
     }
-    return body;
   }
 
   extract(body: any): string {

packages/slackbot-proxy/src/services/growi-uri-injector/GrowiUriInjector.ts

@@ -1,7 +1,7 @@
 
 export interface GrowiUriInjector {
 
-  inject(body: any, growiUri:string): any;
+  inject(body: any, growiUri:string): void;
 
   extract(body: any): string;
 }

packages/slackbot-proxy/src/services/growi-uri-injector/index.ts

@@ -5,11 +5,15 @@ import { GrowiUriInjectionButtonDelegator } from './GrowiUriInjectionButtonDeleg
 
 const logger = loggerFactory('growi-uri-injector:growiUriInjectorFactory');
 
-type DelegatorType = 'MODAL' | 'BUTTON';
+export const DelegatorType = {
+  MODAL: 'modal',
+  BUTTON: 'button',
+} as const;
+export type DelegatorType = typeof DelegatorType[keyof typeof DelegatorType];
 
 const TypeToDelegatorMappings:{[key in DelegatorType]:GrowiUriInjector} = {
-  MODAL: new GrowiUriInjectionModalDelegator(),
-  BUTTON: new GrowiUriInjectionButtonDelegator(),
+  [DelegatorType.MODAL]: new GrowiUriInjectionModalDelegator(),
+  [DelegatorType.BUTTON]: new GrowiUriInjectionButtonDelegator(),
 };