Browse Source

133069 add early return

soumaeda 2 years ago
parent
commit
fefa008dd3

+ 5 - 8
packages/editor/src/services/codemirror-editor/use-codemirror-editor/utils/insert-markdown-text.ts

@@ -15,16 +15,13 @@ export const useInsertMarkdownText = (view?: EditorView): InsertMarkdownText =>
       view?.state.selection.main.to,
     );
     const cursorPos = view?.state.selection.main.head;
-    let curPosAfterReplacing = {};
     const insertText = view?.state.replaceSelection(prefix + selection + suffix);
 
-    if (insertText) {
-      view?.dispatch(insertText);
-      if (cursorPos) {
-        curPosAfterReplacing = cursorPos + prefix.length;
-      }
-      view?.dispatch({ selection: { anchor: curPosAfterReplacing as number } });
-      view?.focus();
+    if (insertText == null || cursorPos == null) {
+      return;
     }
+    view?.dispatch(insertText);
+    view?.dispatch({ selection: { anchor: cursorPos + prefix.length } });
+    view?.focus();
   }, [view]);
 };