Closing the stream by finally

apps/app/src/server/service/attachment.js

@@ -43,14 +43,14 @@ class AttachmentService {
       throw new Error(res.errorMessage);
     }
 
+    const readStreamForCreateAttachmentDocument = createReadStream(file.path);
+
     // create an Attachment document and upload file
     let attachment;
     try {
-      const readStreamForCreateAttachmentDocument = createReadStream(file.path);
       attachment = Attachment.createWithoutSave(pageId, user, file.originalname, file.mimetype, file.size, attachmentType);
       await fileUploadService.uploadAttachment(readStreamForCreateAttachmentDocument, attachment);
       await attachment.save();
-      readStreamForCreateAttachmentDocument.destroy();
 
       //  Creates a new stream for each operation instead of reusing the original stream.
       //  REASON: Node.js Readable streams cannot be reused after consumption.
@@ -80,6 +80,9 @@ class AttachmentService {
       disposeTmpFileCallback?.(file);
       throw err;
     }
+    finally {
+      readStreamForCreateAttachmentDocument.destroy();
+    }
 
     return attachment;
   }