Explorar o código

instanciate at first
fix: https://redmine.weseek.co.jp/issues/160028

Yuki Takei hai 1 ano
pai
achega
ed87f4773e

+ 2 - 5
apps/app/src/server/crowi/index.js

@@ -27,7 +27,7 @@ import { configManager as configManagerSingletonInstance } from '../service/conf
 import { instanciate as instanciateExternalAccountService } from '../service/external-account';
 import { FileUploader, getUploader } from '../service/file-uploader'; // eslint-disable-line no-unused-vars
 import { G2GTransferPusherService, G2GTransferReceiverService } from '../service/g2g-transfer';
-import { GrowiInfoService } from '../service/growi-info';
+import { serviceFactory as growiInfoServiceFactory } from '../service/growi-info';
 import { initializeImportService } from '../service/import';
 import { InstallerService } from '../service/installer';
 import { normalizeData } from '../service/normalize-data';
@@ -71,9 +71,6 @@ class Crowi {
   /** @type {FileUploader} */
   fileUploadService;
 
-  /** @type {GrowiInfoService} */
-  growiInfoService;
-
   /** @type {import('../service/page').IPageService} */
   pageService;
 
@@ -653,7 +650,7 @@ Crowi.prototype.setUpApp = async function() {
  * setup GrowiInfoService
  */
 Crowi.prototype.setupGrowiInfoService = async function() {
-  this.growiInfoService = new GrowiInfoService(this);
+  growiInfoServiceFactory(this);
 };
 
 /**

+ 3 - 2
apps/app/src/server/service/growi-info/growi-info.integ.ts

@@ -8,7 +8,8 @@ import { configManager } from '~/server/service/config-manager';
 
 import type Crowi from '../../crowi';
 
-import { GrowiInfoService } from './growi-info';
+import type { GrowiInfoService } from './growi-info';
+import { serviceFactory } from './growi-info';
 
 describe('GrowiInfoService', () => {
   const appVersion = pkg.version;
@@ -47,7 +48,7 @@ describe('GrowiInfoService', () => {
       },
     });
 
-    growiInfoService = new GrowiInfoService(crowiMock);
+    growiInfoService = serviceFactory(crowiMock);
 
     const userModelFactory = (await import('~/server/models/user')).default;
     User = userModelFactory(crowiMock);