소스 검색

remove useEffect and rename mutate

kaori 4 년 전
부모
커밋
eb23db612f
2개의 변경된 파일4개의 추가작업 그리고 12개의 파일을 삭제
  1. 4 11
      packages/app/src/components/Me/BasicInfoSettings.tsx
  2. 0 1
      packages/app/src/stores/personal-settings.tsx

+ 4 - 11
packages/app/src/components/Me/BasicInfoSettings.tsx

@@ -1,4 +1,4 @@
-import React, { useEffect } from 'react';
+import React from 'react';
 
 import { useTranslation } from 'react-i18next';
 
@@ -17,18 +17,11 @@ const BasicInfoSettings = (props: Props) => {
   const { t } = useTranslation();
   const { appContainer } = props;
 
+  const { mutate: mutateDatabaseData } = useSWRxPersonalSettings();
   const {
-    data: personalSettingsDataFromDB,
-    mutate: mutateDatabaseData,
-  } = useSWRxPersonalSettings();
-  const {
-    data: personalSettingsInfo, mutate, sync, updateBasicInfo, error,
+    data: personalSettingsInfo, mutate: mutatePersonalSettings, sync, updateBasicInfo, error,
   } = usePersonalSettings();
 
-  useEffect(() => {
-    sync();
-  // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [personalSettingsDataFromDB]);
 
   const submitHandler = async() => {
 
@@ -51,7 +44,7 @@ const BasicInfoSettings = (props: Props) => {
     if (personalSettingsInfo == null) {
       return;
     }
-    mutate({ ...personalSettingsInfo, ...updateData });
+    mutatePersonalSettings({ ...personalSettingsInfo, ...updateData });
   };
 
 

+ 0 - 1
packages/app/src/stores/personal-settings.tsx

@@ -22,7 +22,6 @@ export type IPersonalSettingsInfoOption = {
 
 export const usePersonalSettings = (): SWRResponse<IUser, Error> & IPersonalSettingsInfoOption => {
   const { data: personalSettingsDataFromDB } = useSWRxPersonalSettings();
-
   const key = personalSettingsDataFromDB != null ? 'personalSettingsInfo' : null;
 
   const swrResult = useStaticSWR<IUser, Error>(key, undefined, { fallbackData: personalSettingsDataFromDB });