hakumizuki 4 лет назад
Родитель
Сommit
eb0f9bdf70

+ 0 - 1
packages/slack/src/index.ts

@@ -9,7 +9,6 @@ export const supportedGrowiCommands: string[] = [
 ];
 ];
 
 
 export * from './interfaces/growi-command';
 export * from './interfaces/growi-command';
-export * from './interfaces/http-errors';
 export * from './interfaces/request-between-growi-and-proxy';
 export * from './interfaces/request-between-growi-and-proxy';
 export * from './interfaces/request-from-slack';
 export * from './interfaces/request-from-slack';
 export * from './models/errors';
 export * from './models/errors';

+ 1 - 1
packages/slack/src/middlewares/verify-slack-request.ts

@@ -51,7 +51,7 @@ export const verifySlackRequest = (req: RequestFromSlack, res: Response, next: N
     return next();
     return next();
   }
   }
 
 
-  const message = 'Verification fail';
+  const message = 'Verification failed.';
   logger.warn(message, { body: req.body });
   logger.warn(message, { body: req.body });
   return next(createError(403, message));
   return next(createError(403, message));
 };
 };

+ 1 - 2
packages/slackbot-proxy/src/controllers/slack.ts

@@ -3,7 +3,6 @@ import {
 } from '@tsed/common';
 } from '@tsed/common';
 
 
 import axios from 'axios';
 import axios from 'axios';
-import createError from 'http-errors';
 
 
 import { WebAPICallResult } from '@slack/web-api';
 import { WebAPICallResult } from '@slack/web-api';
 
 
@@ -94,7 +93,7 @@ export class SlackCtrl {
   }
   }
 
 
   @Post('/commands')
   @Post('/commands')
-  @UseBefore(AddSigningSecretToReq, verifySlackRequest, (req, res, next) => { return next(createError('Error DETEMASUYO!')) }, AuthorizeCommandMiddleware)
+  @UseBefore(AddSigningSecretToReq, verifySlackRequest, AuthorizeCommandMiddleware)
   async handleCommand(@Req() req: SlackOauthReq, @Res() res: Res): Promise<void|string|Res|WebAPICallResult> {
   async handleCommand(@Req() req: SlackOauthReq, @Res() res: Res): Promise<void|string|Res|WebAPICallResult> {
     const { body, authorizeResult } = req;
     const { body, authorizeResult } = req;