Просмотр исходного кода

Use USER_PUBLIC_FIELDS of User model

Sotaro KARASAWA 10 лет назад
Родитель
Сommit
e79c09d03f
1 измененных файлов с 12 добавлено и 8 удалено
  1. 12 8
      lib/models/page.js

+ 12 - 8
lib/models/page.js

@@ -7,7 +7,6 @@ module.exports = function(crowi) {
     , GRANT_SPECIFIED = 3
     , GRANT_SPECIFIED = 3
     , GRANT_OWNER = 4
     , GRANT_OWNER = 4
     , PAGE_GRANT_ERROR = 1
     , PAGE_GRANT_ERROR = 1
-    , USER_PUBLIC_FIELDS = '_id fbId image googleId name username email status createdAt' // TODO: どこか別の場所へ...
     , pageSchema;
     , pageSchema;
 
 
   function isPortalPath(path) {
   function isPortalPath(path) {
@@ -170,6 +169,7 @@ module.exports = function(crowi) {
 
 
   pageSchema.statics.populatePageData = function(pageData, revisionId) {
   pageSchema.statics.populatePageData = function(pageData, revisionId) {
     var Page = crowi.model('Page');
     var Page = crowi.model('Page');
+    var User = crowi.model('User');
 
 
     pageData.latestRevision = pageData.revision;
     pageData.latestRevision = pageData.revision;
     if (revisionId) {
     if (revisionId) {
@@ -180,12 +180,12 @@ module.exports = function(crowi) {
 
 
     return new Promise(function(resolve, reject) {
     return new Promise(function(resolve, reject) {
       pageData.populate([
       pageData.populate([
-        {path: 'creator', model: 'User', select: USER_PUBLIC_FIELDS},
+        {path: 'creator', model: 'User', select: User.USER_PUBLIC_FIELDS},
         {path: 'revision', model: 'Revision'},
         {path: 'revision', model: 'Revision'},
         //{path: 'liker', options: { limit: 11 }},
         //{path: 'liker', options: { limit: 11 }},
         //{path: 'seenUsers', options: { limit: 11 }},
         //{path: 'seenUsers', options: { limit: 11 }},
       ], function (err, pageData) {
       ], function (err, pageData) {
-        Page.populate(pageData, {path: 'revision.author', model: 'User', select: USER_PUBLIC_FIELDS}, function(err, data) {
+        Page.populate(pageData, {path: 'revision.author', model: 'User', select: User.USER_PUBLIC_FIELDS}, function(err, data) {
           if (err) {
           if (err) {
             return reject(err);
             return reject(err);
           }
           }
@@ -198,12 +198,13 @@ module.exports = function(crowi) {
 
 
   pageSchema.statics.populatePageList = function(pageList) {
   pageSchema.statics.populatePageList = function(pageList) {
     var Page = self;
     var Page = self;
+    var User = crowi.model('User');
 
 
     return new Promise(function(resolve, reject) {
     return new Promise(function(resolve, reject) {
       Page.populate(
       Page.populate(
         pageList,
         pageList,
         [
         [
-          {path: 'creator', model: 'User', select: USER_PUBLIC_FIELDS},
+          {path: 'creator', model: 'User', select: User.USER_PUBLIC_FIELDS},
           {path: 'revision', model: 'Revision'}
           {path: 'revision', model: 'Revision'}
         ],
         ],
         function(err, pageList) {
         function(err, pageList) {
@@ -211,7 +212,7 @@ module.exports = function(crowi) {
             return reject(err);
             return reject(err);
           }
           }
 
 
-          Page.populate(pageList, {path: 'revision.author', model: 'User', select: USER_PUBLIC_FIELDS}, function(err, data) {
+          Page.populate(pageList, {path: 'revision.author', model: 'User', select: User.USER_PUBLIC_FIELDS}, function(err, data) {
             if (err) {
             if (err) {
               return reject(err);
               return reject(err);
             }
             }
@@ -376,6 +377,7 @@ module.exports = function(crowi) {
 
 
   pageSchema.statics.findListByPageIds = function(ids, option) {
   pageSchema.statics.findListByPageIds = function(ids, option) {
     var Page = this;
     var Page = this;
+    var User = crowi.model('User');
     var limit = option.limit || 50;
     var limit = option.limit || 50;
     var offset = option.skip || 0;
     var offset = option.skip || 0;
 
 
@@ -391,7 +393,7 @@ module.exports = function(crowi) {
             return reject(err);
             return reject(err);
           }
           }
 
 
-          Page.populate(pages, {path: 'revision.author', model: 'User', select: USER_PUBLIC_FIELDS}, function(err, data) {
+          Page.populate(pages, {path: 'revision.author', model: 'User', select: User.USER_PUBLIC_FIELDS}, function(err, data) {
             if (err) {
             if (err) {
               return reject(err);
               return reject(err);
             }
             }
@@ -404,6 +406,7 @@ module.exports = function(crowi) {
 
 
   pageSchema.statics.findListByCreator = function(user, option) {
   pageSchema.statics.findListByCreator = function(user, option) {
     var Page = this;
     var Page = this;
+    var User = crowi.model('User');
     var limit = option.limit || 50;
     var limit = option.limit || 50;
     var offset = option.skip || 0;
     var offset = option.skip || 0;
 
 
@@ -419,7 +422,7 @@ module.exports = function(crowi) {
             return reject(err);
             return reject(err);
           }
           }
 
 
-          Page.populate(pages, {path: 'revision.author', model: 'User', select: USER_PUBLIC_FIELDS}, function(err, data) {
+          Page.populate(pages, {path: 'revision.author', model: 'User', select: User.USER_PUBLIC_FIELDS}, function(err, data) {
             if (err) {
             if (err) {
               return reject(err);
               return reject(err);
             }
             }
@@ -432,6 +435,7 @@ module.exports = function(crowi) {
 
 
   pageSchema.statics.findListByStartWith = function(path, userData, option) {
   pageSchema.statics.findListByStartWith = function(path, userData, option) {
     var Page = this;
     var Page = this;
+    var User = crowi.model('User');
 
 
     if (!option) {
     if (!option) {
       option = {sort: 'updatedAt', desc: -1, offset: 0, limit: 50};
       option = {sort: 'updatedAt', desc: -1, offset: 0, limit: 50};
@@ -470,7 +474,7 @@ module.exports = function(crowi) {
           return reject(err);
           return reject(err);
         }
         }
 
 
-        Page.populate(pages, {path: 'revision.author', model: 'User', select: USER_PUBLIC_FIELDS}, function(err, data) {
+        Page.populate(pages, {path: 'revision.author', model: 'User', select: User.USER_PUBLIC_FIELDS}, function(err, data) {
           if (err) {
           if (err) {
             return reject(err);
             return reject(err);
           }
           }