fix canceling submission

packages/app/src/components/PageCreateModal.jsx

@@ -3,7 +3,6 @@ import React, {
   useEffect, useState, useMemo, useCallback,
 } from 'react';
 import PropTypes from 'prop-types';
-import assert from 'assert';
 
 import { Modal, ModalHeader, ModalBody } from 'reactstrap';
 import { debounce } from 'throttle-debounce';
@@ -132,17 +131,6 @@ const PageCreateModal = (props) => {
     redirectToEditor(pageNameInput);
   }
 
-  const ppacChangeHandler = useCallback((data) => {
-    assert(data.length > 0);
-
-    const page = data[0].data; // should be single page selected
-
-    // navigate to page
-    if (page != null) {
-      window.location.href = `/${page._id}`;
-    }
-  }, []);
-
   function ppacInputChangeHandler(value) {
     setPageNameInput(value);
   }
@@ -223,7 +211,6 @@ const PageCreateModal = (props) => {
                   <PagePathAutoComplete
                     initializedPath={pageNameInput}
                     addTrailingSlash
-                    onChange={ppacChangeHandler}
                     onSubmit={ppacSubmitHandler}
                     onInputChange={ppacInputChangeHandler}
                     autoFocus

packages/app/src/components/PageDuplicateModal.tsx

@@ -1,7 +1,6 @@
 import React, {
   useState, useEffect, useCallback, useMemo,
 } from 'react';
-import assert from 'assert';
 
 import {
   Modal, ModalHeader, ModalBody, ModalFooter,
@@ -83,17 +82,6 @@ const PageDuplicateModal = (): JSX.Element => {
     }
   }, [pageNameInput, subordinatedPages, checkExistPathsDebounce, page]);
 
-  const ppacChangeHandler = useCallback((data) => {
-    assert(data.length > 0);
-
-    const page = data[0].data; // should be single page selected
-
-    // navigate to page
-    if (page != null) {
-      window.location.href = `/${page._id}`;
-    }
-  }, []);
-
   /**
    * change pageNameInput for PagePathAutoComplete
    * @param {string} value
@@ -194,7 +182,6 @@ const PageDuplicateModal = (): JSX.Element => {
                 ? (
                   <PagePathAutoComplete
                     initializedPath={path}
-                    onChange={ppacChangeHandler}
                     onSubmit={duplicate}
                     onInputChange={ppacInputChangeHandler}
                     autoFocus

packages/app/src/components/SearchTypeahead.tsx

@@ -130,11 +130,12 @@ const SearchTypeahead: ForwardRefRenderFunction<IFocusable, Props> = (props: Pro
   const timeoutIdRef = useRef<NodeJS.Timeout>();
 
   const changeHandler = useCallback((selectedItems: IPageWithMeta<IPageSearchMeta>[]) => {
+    // cancel schedule to submit
+    if (timeoutIdRef.current != null) {
+      clearTimeout(timeoutIdRef.current);
+    }
+
     if (onChange != null && selectedItems.length > 0) {
-      // cancel schedule to submit
-      if (timeoutIdRef.current != null) {
-        clearTimeout(timeoutIdRef.current);
-      }
       onChange(selectedItems);
     }
   }, [onChange]);