Просмотр исходного кода

remove dependency cycle lint error

reiji-h 2 лет назад
Родитель
Сommit
e34b65ec4d

+ 0 - 1
apps/app/src/client/services/renderer/renderer.tsx

@@ -19,7 +19,6 @@ import { DrawioViewerWithEditButton } from '~/components/ReactMarkdownComponents
 import { Header } from '~/components/ReactMarkdownComponents/Header';
 import { LightBox } from '~/components/ReactMarkdownComponents/LightBox';
 import { RichAttachment } from '~/components/ReactMarkdownComponents/RichAttachment';
-// eslint-disable-next-line import/no-cycle
 import { SlideViewer } from '~/components/ReactMarkdownComponents/SlideViewer';
 import { TableWithEditButton } from '~/components/ReactMarkdownComponents/TableWithEditButton';
 import * as mermaid from '~/features/mermaid';

+ 1 - 4
apps/app/src/components/ReactMarkdownComponents/SlideViewer.tsx

@@ -4,10 +4,7 @@ import { MARP_CONTAINER_CLASS_NAME } from '@growi/presentation';
 import dynamic from 'next/dynamic';
 import { ReactMarkdownOptions } from 'react-markdown/lib/react-markdown';
 
-// TODO: Fix Dependency cycle
-// https://redmine.weseek.co.jp/issues/126744
-// eslint-disable-next-line import/no-cycle
-import { usePresentationViewOptions } from '~/stores/renderer';
+import { usePresentationViewOptions } from './SlideViewerRenderer';
 
 
 const Slides = dynamic(() => import('@growi/presentation').then(mod => mod.Slides), { ssr: false });

+ 0 - 1
apps/app/src/stores/renderer.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-cycle */
 import { useCallback } from 'react';
 
 import type { HtmlElementNode } from 'rehype-toc';