Shun Miyazawa 4 年之前
父節點
當前提交
d3d846e8be
共有 1 個文件被更改,包括 3 次插入4 次删除
  1. 3 4
      packages/app/src/server/service/activity.ts

+ 3 - 4
packages/app/src/server/service/activity.ts

@@ -39,12 +39,11 @@ class ActivityService {
     const shouldNotification = activity != null && target != null && (AllSupportedActionToNotifiedType as ReadonlyArray<string>).includes(activity.action);
     if (shouldNotification) {
       const notificationTargetUsers = await activity?.getNotificationTargetUsers();
-      let snapshotForInAppNotification: string;
       if (target != null) {
-        snapshotForInAppNotification = stringifySnapshot(target);
+        const snapshotForInAppNotification = stringifySnapshot(target);
+        await this.inAppNotificationService.upsertByActivity(notificationTargetUsers, activity, snapshotForInAppNotification);
+        await this.inAppNotificationService.emitSocketIo(notificationTargetUsers);
       }
-      await this.inAppNotificationService.upsertByActivity(notificationTargetUsers, activity, snapshotForInAppNotification);
-      await this.inAppNotificationService.emitSocketIo(notificationTargetUsers);
     }
   };