Просмотр исходного кода

Merge pull request #10292 from growilabs/feat/163220-171243-enable-page-bulk-export-for-growi-cloud

feat: Enable page bulk export for GROWI.cloud
mergify[bot] 4 месяцев назад
Родитель
Сommit
c8eb5f122c

+ 5 - 8
apps/app/src/client/components/Admin/App/AppSettingsPageContents.tsx

@@ -108,15 +108,12 @@ const AppSettingsPageContents = (props: Props) => {
         </div>
         </div>
       </div>
       </div>
 
 
-      {/* TODO: Enable configuring bulk export for GROWI.cloud when it can be relased for cloud (https://redmine.weseek.co.jp/issues/163220) */}
-      {!adminAppContainer.state.isBulkExportDisabledForCloud && (
-        <div className="row mt-5">
-          <div className="col-lg-12">
-            <h2 className="admin-setting-header">{t('admin:app_setting.page_bulk_export_settings')}</h2>
-            <PageBulkExportSettings />
-          </div>
+      <div className="row mt-5">
+        <div className="col-lg-12">
+          <h2 className="admin-setting-header">{t('admin:app_setting.page_bulk_export_settings')}</h2>
+          <PageBulkExportSettings />
         </div>
         </div>
-      )}
+      </div>
 
 
       <div className="row">
       <div className="row">
         <div className="col-lg-12">
         <div className="col-lg-12">

+ 0 - 6
apps/app/src/client/services/AdminAppContainer.js

@@ -41,9 +41,6 @@ export default class AdminAppContainer extends Container {
       sesSecretAccessKey: '',
       sesSecretAccessKey: '',
 
 
       isMaintenanceMode: false,
       isMaintenanceMode: false,
-
-      // TODO: remove this property when bulk export can be relased for cloud (https://redmine.weseek.co.jp/issues/163220)
-      isBulkExportDisabledForCloud: false,
     };
     };
 
 
   }
   }
@@ -84,9 +81,6 @@ export default class AdminAppContainer extends Container {
       sesSecretAccessKey: appSettingsParams.sesSecretAccessKey,
       sesSecretAccessKey: appSettingsParams.sesSecretAccessKey,
 
 
       isMaintenanceMode: appSettingsParams.isMaintenanceMode,
       isMaintenanceMode: appSettingsParams.isMaintenanceMode,
-
-      // TODO: remove this property when bulk export can be relased for cloud (https://redmine.weseek.co.jp/issues/163220)
-      isBulkExportDisabledForCloud: appSettingsParams.isBulkExportDisabledForCloud,
     });
     });
   }
   }
 
 

+ 3 - 4
apps/app/src/features/page-bulk-export/server/service/check-page-bulk-export-job-in-progress-cron.ts

@@ -22,10 +22,9 @@ class CheckPageBulkExportJobInProgressCronService extends CronService {
   }
   }
 
 
   override async executeJob(): Promise<void> {
   override async executeJob(): Promise<void> {
-    // TODO: remove growiCloudUri condition when bulk export can be relased for GROWI.cloud (https://redmine.weseek.co.jp/issues/163220)
-    const isBulkExportPagesEnabled =
-      configManager.getConfig('app:isBulkExportPagesEnabled') &&
-      configManager.getConfig('app:growiCloudUri') == null;
+    const isBulkExportPagesEnabled = configManager.getConfig(
+      'app:isBulkExportPagesEnabled',
+    );
     if (!isBulkExportPagesEnabled) return;
     if (!isBulkExportPagesEnabled) return;
 
 
     const pageBulkExportJobInProgress = await PageBulkExportJob.findOne({
     const pageBulkExportJobInProgress = await PageBulkExportJob.findOne({

+ 3 - 4
apps/app/src/pages/[[...path]].page.tsx

@@ -774,10 +774,9 @@ function injectServerConfigurations(
   );
   );
   props.isUploadAllFileAllowed = fileUploadService.getFileUploadEnabled();
   props.isUploadAllFileAllowed = fileUploadService.getFileUploadEnabled();
   props.isUploadEnabled = fileUploadService.getIsUploadable();
   props.isUploadEnabled = fileUploadService.getIsUploadable();
-  // TODO: remove growiCloudUri condition when bulk export can be relased for GROWI.cloud (https://redmine.weseek.co.jp/issues/163220)
-  props.isBulkExportPagesEnabled =
-    configManager.getConfig('app:isBulkExportPagesEnabled') &&
-    configManager.getConfig('app:growiCloudUri') == null;
+  props.isBulkExportPagesEnabled = configManager.getConfig(
+    'app:isBulkExportPagesEnabled',
+  );
   props.isPdfBulkExportEnabled =
   props.isPdfBulkExportEnabled =
     configManager.getConfig('app:pageBulkExportPdfConverterUri') != null;
     configManager.getConfig('app:pageBulkExportPdfConverterUri') != null;
 
 

+ 0 - 2
apps/app/src/server/routes/apiv3/app-settings/index.ts

@@ -442,8 +442,6 @@ module.exports = (crowi) => {
       isBulkExportPagesEnabled: configManager.getConfig('app:isBulkExportPagesEnabled'),
       isBulkExportPagesEnabled: configManager.getConfig('app:isBulkExportPagesEnabled'),
       envIsBulkExportPagesEnabled: configManager.getConfig('app:isBulkExportPagesEnabled'),
       envIsBulkExportPagesEnabled: configManager.getConfig('app:isBulkExportPagesEnabled'),
       bulkExportDownloadExpirationSeconds: configManager.getConfig('app:bulkExportDownloadExpirationSeconds'),
       bulkExportDownloadExpirationSeconds: configManager.getConfig('app:bulkExportDownloadExpirationSeconds'),
-      // TODO: remove this property when bulk export can be relased for cloud (https://redmine.weseek.co.jp/issues/163220)
-      isBulkExportDisabledForCloud: configManager.getConfig('app:growiCloudUri') != null,
     };
     };
     return res.apiv3({ appSettingsParams });
     return res.apiv3({ appSettingsParams });