simprify Crowi class by removing some getter function

apps/app/src/server/crowi/index.js

@@ -1,10 +1,10 @@
 import next from 'next';
+import http from 'node:http';
+import path from 'node:path';
 import { createTerminus } from '@godaddy/terminus';
 import attachmentRoutes from '@growi/remark-attachment-refs/dist/server';
 import lsxRoutes from '@growi/remark-lsx/dist/server/index.cjs';
-import http from 'http';
 import mongoose from 'mongoose';
-import path from 'path';
 
 import { KeycloakUserGroupSyncService } from '~/features/external-user-group/server/service/keycloak-user-group-sync';
 import { LdapUserGroupSyncService } from '~/features/external-user-group/server/service/ldap-user-group-sync';
@@ -47,11 +47,7 @@ import { SocketIoService } from '../service/socket-io';
 import UserGroupService from '../service/user-group';
 import { UserNotificationService } from '../service/user-notification';
 import { initializeYjsService } from '../service/yjs';
-import {
-  getModelSafely,
-  getMongoUri,
-  mongoOptions,
-} from '../util/mongoose-utils';
+import { getMongoUri, mongoOptions } from '../util/mongoose-utils';
 import { setupModelsDependentOnCrowi } from './setup-models';
 
 const logger = loggerFactory('growi:crowi');
@@ -117,6 +113,21 @@ class Crowi {
   /** @type UserNotificationService */
   userNotificationService;
 
+  /** @type {UserGroupService} */
+  userGroupService;
+
+  /** @type {import('~/features/external-user-group/server/service/ldap-user-group-sync').LdapUserGroupSyncService} */
+  ldapUserGroupSyncService;
+
+  /** @type {import('~/features/external-user-group/server/service/keycloak-user-group-sync').KeycloakUserGroupSyncService} */
+  keycloakUserGroupSyncService;
+
+  /** @type {import('../service/global-notification').GlobalNotificationService} */
+  globalNotificationService;
+
+  /** @type {any} */
+  sessionConfig;
+
   constructor() {
     this.version = getGrowiVersion();
 
@@ -379,14 +390,6 @@ Crowi.prototype.getSlackLegacy = function () {
   return this.slackLegacy;
 };
 
-Crowi.prototype.getGlobalNotificationService = function () {
-  return this.globalNotificationService;
-};
-
-Crowi.prototype.getUserNotificationService = function () {
-  return this.userNotificationService;
-};
-
 Crowi.prototype.setupPassport = async function () {
   logger.debug('Passport is enabled');
 

apps/app/src/server/routes/apiv3/page/index.ts

@@ -93,7 +93,7 @@ module.exports = (crowi: Crowi) => {
   );
   const addActivity = generateAddActivityMiddleware();
 
-  const globalNotificationService = crowi.getGlobalNotificationService();
+  const globalNotificationService = crowi.globalNotificationService;
   const Page = mongoose.model<IPage, PageModel>('Page');
   const { pageService, pageGrantService } = crowi;
 
@@ -1102,7 +1102,9 @@ module.exports = (crowi: Crowi) => {
       }
 
       res.set({
-        'Content-Disposition': `attachment;filename*=UTF-8''${encodeURIComponent(fileName)}.${format}`,
+        'Content-Disposition': `attachment;filename*=UTF-8''${encodeURIComponent(
+          fileName,
+        )}.${format}`,
       });
 
       const parameters = {

apps/app/src/server/routes/apiv3/pages/index.js

@@ -50,7 +50,7 @@ module.exports = (crowi) => {
 
   const activityEvent = crowi.events.activity;
 
-  const globalNotificationService = crowi.getGlobalNotificationService();
+  const globalNotificationService = crowi.globalNotificationService;
 
   const addActivity = generateAddActivityMiddleware(crowi);
 

apps/app/src/server/routes/comment.js

@@ -65,8 +65,8 @@ module.exports = (crowi, _app) => {
 
   const activityEvent = crowi.events.activity;
 
-  const globalNotificationService = crowi.getGlobalNotificationService();
-  const userNotificationService = crowi.getUserNotificationService();
+  const globalNotificationService = crowi.globalNotificationService;
+  const userNotificationService = crowi.userNotificationService;
 
   const { body } = require('express-validator');
   const mongoose = require('mongoose');

apps/app/src/server/routes/page.js

@@ -27,7 +27,7 @@ module.exports = (crowi, _app) => {
 
   const ApiResponse = require('../util/apiResponse');
 
-  const globalNotificationService = crowi.getGlobalNotificationService();
+  const globalNotificationService = crowi.globalNotificationService;
 
   const actions = {};