Просмотр исходного кода

Merge branch 'feat/growi-bot' into feat/6285-6287-display-modal-for-select-growi

itizawa 4 лет назад
Родитель
Сommit
bc326bb02f

+ 5 - 0
packages/slackbot-proxy/src/middlewares/slack-to-growi/extract-growi-uri-from-req.ts

@@ -10,6 +10,11 @@ export class ExtractGrowiUriFromReq implements IMiddleware {
 
   use(@Req() req: Req & SlackOauthReq, @Res() res: Res, @Next() next: Next): void {
 
+    // There is no payload in the request from slack
+    if (req.body.payload == null) {
+      return next();
+    }
+
     const payload = JSON.parse(req.body.payload);
 
     // extract for modal

+ 3 - 6
src/server/models/page.js

@@ -985,9 +985,8 @@ module.exports = function(crowi) {
     savedPage = await this.findByPath(revision.path);
     await savedPage.populateDataToShowRevision();
 
-    if (socketClientId != null) {
-      pageEvent.emit('create', savedPage, user, socketClientId);
-    }
+    pageEvent.emit('create', savedPage, user, socketClientId);
+
     return savedPage;
   };
 
@@ -1014,9 +1013,7 @@ module.exports = function(crowi) {
       savedPage = await this.syncRevisionToHackmd(savedPage);
     }
 
-    if (socketClientId != null) {
-      pageEvent.emit('update', savedPage, user, socketClientId);
-    }
+    pageEvent.emit('update', savedPage, user, socketClientId);
 
     return savedPage;
   };