Browse Source

abbreviate too long words and remove null check for onSwitch

kaoritokashiki 5 years ago
parent
commit
ba3338a742
1 changed files with 11 additions and 18 deletions
  1. 11 18
      src/client/js/components/PageAccessoriesModal.jsx

+ 11 - 18
src/client/js/components/PageAccessoriesModal.jsx

@@ -18,6 +18,8 @@ import PageAttachment from './PageAttachment';
 
 
 const PageAccessoriesModal = (props) => {
 const PageAccessoriesModal = (props) => {
   const { t, pageAccessoriesContainer } = props;
   const { t, pageAccessoriesContainer } = props;
+  const { switchActiveTab } = pageAccessoriesContainer;
+  const { activeTab } = pageAccessoriesContainer.state;
 
 
   function closeModalHandler() {
   function closeModalHandler() {
     if (props.onClose == null) {
     if (props.onClose == null) {
@@ -26,14 +28,6 @@ const PageAccessoriesModal = (props) => {
     props.onClose();
     props.onClose();
   }
   }
 
 
-  function switchTabHandler(clickedTab) {
-    // if (pageAccessoriesContainer.state.activeTab == null) {
-    // if (pageAccessoriesContainer.switchActiveTab == null) {
-    //   return;
-    // }
-    pageAccessoriesContainer.switchActiveTab(clickedTab);
-  }
-
   return (
   return (
     <React.Fragment>
     <React.Fragment>
       <Modal
       <Modal
@@ -44,36 +38,36 @@ const PageAccessoriesModal = (props) => {
       >
       >
         <ModalBody>
         <ModalBody>
           <Nav className="nav-title border-bottom">
           <Nav className="nav-title border-bottom">
-            <NavItem className={`nav-link ${pageAccessoriesContainer.state.activeTab === 'pagelist' && 'active active-border'}`}>
+            <NavItem className={`nav-link ${activeTab === 'pagelist' && 'active active-border'}`}>
               <NavLink
               <NavLink
-                onClick={() => { switchTabHandler('pagelist') }}
+                onClick={() => { switchActiveTab('pagelist') }}
                 href="#pagelist"
                 href="#pagelist"
               >
               >
                 <PageListIcon />
                 <PageListIcon />
                 { t('page_list') }
                 { t('page_list') }
               </NavLink>
               </NavLink>
             </NavItem>
             </NavItem>
-            <NavItem className={`nav-link ${pageAccessoriesContainer.state.activeTab === 'timeline' && 'active active-border'}`}>
+            <NavItem className={`nav-link ${activeTab === 'timeline' && 'active active-border'}`}>
               <NavLink
               <NavLink
-                onClick={() => { switchTabHandler('timeline') }}
+                onClick={() => { switchActiveTab('timeline') }}
                 href="#timeline"
                 href="#timeline"
               >
               >
                 <TimeLineIcon />
                 <TimeLineIcon />
                 { t('Timeline View') }
                 { t('Timeline View') }
               </NavLink>
               </NavLink>
             </NavItem>
             </NavItem>
-            <NavItem className={`nav-link ${pageAccessoriesContainer.state.activeTab === 'recent-changes' && 'active active-border'}`}>
+            <NavItem className={`nav-link ${activeTab === 'recent-changes' && 'active active-border'}`}>
               <NavLink
               <NavLink
-                onClick={() => { switchTabHandler('recent-changes') }}
+                onClick={() => { switchActiveTab('recent-changes') }}
                 href="#recent-changes"
                 href="#recent-changes"
               >
               >
                 <RecentChangesIcon />
                 <RecentChangesIcon />
                 { t('History') }
                 { t('History') }
               </NavLink>
               </NavLink>
             </NavItem>
             </NavItem>
-            <NavItem className={`nav-link ${pageAccessoriesContainer.state.activeTab === 'attachment' && 'active active-border'}`}>
+            <NavItem className={`nav-link ${activeTab === 'attachment' && 'active active-border'}`}>
               <NavLink
               <NavLink
-                onClick={() => { switchTabHandler('attachment') }}
+                onClick={() => { switchActiveTab('attachment') }}
                 href="#attachment"
                 href="#attachment"
               >
               >
                 <AttachmentIcon />
                 <AttachmentIcon />
@@ -81,7 +75,7 @@ const PageAccessoriesModal = (props) => {
               </NavLink>
               </NavLink>
             </NavItem>
             </NavItem>
           </Nav>
           </Nav>
-          <TabContent activeTab={pageAccessoriesContainer.state.activeTab}>
+          <TabContent activeTab={activeTab}>
             <TabPane tabId="pagelist"></TabPane>
             <TabPane tabId="pagelist"></TabPane>
             <TabPane tabId="timeline"></TabPane>
             <TabPane tabId="timeline"></TabPane>
             <TabPane tabId="recent-changes"></TabPane>
             <TabPane tabId="recent-changes"></TabPane>
@@ -112,7 +106,6 @@ PageAccessoriesModal.propTypes = {
   onClose: PropTypes.func,
   onClose: PropTypes.func,
   activeTab: PropTypes.string.isRequired,
   activeTab: PropTypes.string.isRequired,
   // activeComponents: PropTypes.object.isRequired,
   // activeComponents: PropTypes.object.isRequired,
-  // onSwitch: PropTypes.func,
 };
 };
 
 
 export default withTranslation()(PageAccessoriesModalWrapper);
 export default withTranslation()(PageAccessoriesModalWrapper);