Browse Source

Fix logic for user homepage deletion checks in PageService

Shun Miyazawa 3 months ago
parent
commit
b9ae60adb3
1 changed files with 5 additions and 9 deletions
  1. 5 9
      apps/app/src/server/service/page/index.ts

+ 5 - 9
apps/app/src/server/service/page/index.ts

@@ -630,16 +630,12 @@ class PageService implements IPageService {
       return await this.isUsersHomepageOwnerAbsent(page.path);
       return await this.isUsersHomepageOwnerAbsent(page.path);
     })();
     })();
 
 
-    const isDeletable = canDeleteUserHomepage;
-    this.canDelete(page, creatorId, user, false) && canDeleteUserHomepage;
+    const isDeletable =
+      canDeleteUserHomepage && this.canDelete(page, creatorId, user, false);
+
     const isAbleToDeleteCompletely =
     const isAbleToDeleteCompletely =
-      this.canDeleteCompletely(
-        page,
-        creatorId,
-        user,
-        false,
-        userRelatedGroups,
-      ) && canDeleteUserHomepage; // use normal delete config
+      canDeleteUserHomepage &&
+      this.canDeleteCompletely(page, creatorId, user, false, userRelatedGroups); // use normal delete config
 
 
     const isBookmarked: boolean = isGuestUser
     const isBookmarked: boolean = isGuestUser
       ? false
       ? false