ryosei-f пре 1 месец
родитељ
комит
b5921e582f

+ 2 - 2
apps/app/src/features/audit-log-bulk-export/server/routes/apiv3/audit-log-bulk-export.integ.ts

@@ -208,13 +208,13 @@ describe('POST /_api/v3/audit-log-bulk-export', () => {
       expect(res.body?.errors).toBeDefined();
     });
 
-    it('returns 400 when users contains invalid ObjectId', async () => {
+    it('returns 400 when usernames contains non-string values', async () => {
       const app = buildApp();
       const res = await request(app)
         .post('/_api/v3/audit-log-bulk-export')
         .send({
           filters: {
-            users: ['invalid-objectid'],
+            usernames: [123, 456],
           },
         });
 

+ 8 - 13
apps/app/src/features/audit-log-bulk-export/server/service/audit-log-bulk-export-job-cron/audit-log-bulk-export-job-cron-service.integ.ts

@@ -578,11 +578,11 @@ describe('AuditLogBulkExportJobCronService Integration Test', () => {
 
   describe('4. Error Handling', () => {
     describe('4-1. Nonexistent Users Filter', () => {
-      it('should throw error for nonexistent users', async () => {
+      it('should complete with no results for nonexistent usernames', async () => {
         const job = await AuditLogBulkExportJob.create({
           user: testUser._id,
           filters: {
-            users: [new mongoose.Types.ObjectId().toString()],
+            usernames: ['nonexistent-user-xyz-999'],
           },
           format: AuditLogBulkExportFormat.json,
           status: AuditLogBulkExportJobStatus.exporting,
@@ -591,19 +591,14 @@ describe('AuditLogBulkExportJobCronService Integration Test', () => {
           totalExportedCount: 0,
         });
 
-        try {
-          await cronService.proceedBulkExportJob(job);
-          await waitForCondition(async () => {
-            const updatedJob = await AuditLogBulkExportJob.findById(job._id);
-            return updatedJob?.status === AuditLogBulkExportJobStatus.failed;
-          });
-        } catch (_error) {}
+        await cronService.proceedBulkExportJob(job);
+        await waitForCondition(async () => {
+          const updatedJob = await AuditLogBulkExportJob.findById(job._id);
+          return updatedJob?.status === AuditLogBulkExportJobStatus.completed;
+        });
 
         const updatedJob = await AuditLogBulkExportJob.findById(job._id);
-        expect([
-          AuditLogBulkExportJobStatus.exporting,
-          AuditLogBulkExportJobStatus.failed,
-        ]).toContain(updatedJob?.status);
+        expect(updatedJob?.status).toBe(AuditLogBulkExportJobStatus.completed);
       });
     });