Просмотр исходного кода

Merge pull request #9631 from weseek/support/161421-161502-sanitize-attachment-refs-query-params

fix: Add XSS filter to remark-attachment-refs /refs endpoint
mergify[bot] 1 год назад
Родитель
Сommit
af2a3beef7
1 измененных файлов с 3 добавлено и 2 удалено
  1. 3 2
      packages/remark-attachment-refs/src/server/routes/refs.ts

+ 3 - 2
packages/remark-attachment-refs/src/server/routes/refs.ts

@@ -86,6 +86,7 @@ export const routesFactory = (crowi): any => {
   router.get('/ref', accessTokenParser, loginRequired, async(req: RequestWithUser, res) => {
   router.get('/ref', accessTokenParser, loginRequired, async(req: RequestWithUser, res) => {
     const user = req.user;
     const user = req.user;
     const { pagePath, fileNameOrId } = req.query;
     const { pagePath, fileNameOrId } = req.query;
+    const filterXSS = new FilterXSS();
 
 
     if (pagePath == null) {
     if (pagePath == null) {
       res.status(400).send('the param \'pagePath\' must be set.');
       res.status(400).send('the param \'pagePath\' must be set.');
@@ -96,7 +97,7 @@ export const routesFactory = (crowi): any => {
 
 
     // not found
     // not found
     if (page == null) {
     if (page == null) {
-      res.status(404).send(`pagePath: '${pagePath}' is not found or forbidden.`);
+      res.status(404).send(filterXSS.process(`pagePath: '${pagePath}' is not found or forbidden.`));
       return;
       return;
     }
     }
 
 
@@ -117,7 +118,7 @@ export const routesFactory = (crowi): any => {
 
 
     // not found
     // not found
     if (attachment == null) {
     if (attachment == null) {
-      res.status(404).send(`attachment '${fileNameOrId}' is not found.`);
+      res.status(404).send(filterXSS.process(`attachment '${fileNameOrId}' is not found.`));
       return;
       return;
     }
     }