clean code

src/client/js/components/PageHistory/PageRevisionList.js → src/client/js/components/PageHistory/PageRevisionList.jsx

@@ -6,15 +6,33 @@ import RevisionDiff from './RevisionDiff';
 
 export default class PageRevisionList extends React.Component {
 
+  renderRow(revision, previousRevision) {
+    const revisionId = revision._id;
+    const revisionDiffOpened = this.props.diffOpened[revisionId] || false;
+
+    return (
+      <div className="revision-hisory-outer" key={`revision-history-${revisionId}`}>
+        <Revision
+          revision={revision}
+          revisionDiffOpened={revisionDiffOpened}
+          onDiffOpenClicked={this.props.onDiffOpenClicked}
+          key={`revision-history-rev-${revisionId}`}
+          />
+        <RevisionDiff
+          revisionDiffOpened={revisionDiffOpened}
+          currentRevision={revision}
+          previousRevision={previousRevision}
+          key={`revision-deff-${revisionId}`}
+        />
+      </div>
+    );
+  }
+
   render() {
     const revisions = this.props.revisions,
       revisionCount = this.props.revisions.length;
 
     const revisionList = this.props.revisions.map((revision, idx) => {
-      const revisionId = revision._id
-        , revisionDiffOpened = this.props.diffOpened[revisionId] || false;
-
-
       let previousRevision;
       if (idx+1 < revisionCount) {
         previousRevision = revisions[idx + 1];
@@ -23,22 +41,7 @@ export default class PageRevisionList extends React.Component {
         previousRevision = revision; // if it is the first revision, show full text as diff text
       }
 
-      return (
-        <div className="revision-hisory-outer" key={'revision-history-' + revisionId}>
-          <Revision
-            revision={revision}
-            revisionDiffOpened={revisionDiffOpened}
-            onDiffOpenClicked={this.props.onDiffOpenClicked}
-            key={'revision-history-rev-' + revisionId}
-            />
-          <RevisionDiff
-            revisionDiffOpened={revisionDiffOpened}
-            currentRevision={revision}
-            previousRevision={previousRevision}
-            key={'revision-diff-' + revisionId}
-          />
-        </div>
-      );
+      return this.renderRow(revision, previousRevision);
     });
 
     return (