Yuki Takei 7 سال پیش
والد
کامیت
ac6fd28fb6
3فایلهای تغییر یافته به همراه11 افزوده شده و 2 حذف شده
  1. 7 2
      src/server/models/bookmark.js
  2. 2 0
      src/server/models/page.js
  3. 2 0
      src/server/routes/page.js

+ 7 - 2
src/server/models/bookmark.js

@@ -116,8 +116,13 @@ module.exports = function(crowi) {
     });
   };
 
+  /**
+   * Remove bookmark
+   * used only when removing the page
+   * @param {string} pageId
+   */
   bookmarkSchema.statics.removeBookmarksByPageId = function(pageId) {
-    var Bookmark = this;
+    const Bookmark = this;
 
     return new Promise(function(resolve, reject) {
       Bookmark.remove({page: pageId}, function(err, data) {
@@ -132,7 +137,7 @@ module.exports = function(crowi) {
   };
 
   bookmarkSchema.statics.removeBookmark = function(page, user) {
-    var Bookmark = this;
+    const Bookmark = this;
 
     return new Promise(function(resolve, reject) {
       Bookmark.findOneAndRemove({page: page, user: user}, function(err, data) {

+ 2 - 0
src/server/models/page.js

@@ -302,6 +302,8 @@ module.exports = function(crowi) {
     });
   };
 
+  // TODO abolish or migrate
+  // https://weseek.myjetbrains.com/youtrack/issue/GC-1185
   pageSchema.statics.populatePageListToAnyObjects = function(pageIdObjectArray) {
     var Page = this;
     var pageIdMappings = {};

+ 2 - 0
src/server/routes/page.js

@@ -707,6 +707,8 @@ module.exports = function(crowi, app) {
   api.redirector = function(req, res) {
     const id = req.params.id;
 
+    // TODO use findPageByIdAndGrantedUser
+    // https://weseek.myjetbrains.com/youtrack/issue/GC-1224
     Page.findPageById(id)
     .then(function(pageData) {