Explorar el Código

avoid cypress error

jam411 hace 3 años
padre
commit
a974d2fde6

+ 11 - 8
packages/app/test/cypress/integration/10-install/10-install--install.spec.ts

@@ -3,22 +3,24 @@ describe('Install', () => {
 
 
   beforeEach(() => {
   beforeEach(() => {
     cy.visit('/');
     cy.visit('/');
+    cy.getByTestid('installerForm').should('be.visible');
   });
   });
 
 
   it('Successfully show installer', () => {
   it('Successfully show installer', () => {
-    cy.getByTestid('installerForm').should('be.visible');
     cy.screenshot(`${ssPrefix}-redirect-to-installer-page`);
     cy.screenshot(`${ssPrefix}-redirect-to-installer-page`);
   });
   });
 
 
   it('Sccessfully choose languages', () => {
   it('Sccessfully choose languages', () => {
-    cy.getByTestid('installerForm').should('be.visible');
     cy.getByTestid('dropdownLanguage').should('be.visible');
     cy.getByTestid('dropdownLanguage').should('be.visible');
-    // TODO: should not use wait.
-    // eslint-disable-next-line cypress/no-unnecessary-waiting
-    cy.wait(1000); // waiting for load
 
 
-    cy.getByTestid('dropdownLanguage').click();
-    cy.get('.dropdown-menu').should('be.visible');
+    // open Language Dropdown, wait for language data to load
+    cy.waitUntil(() => {
+      // do
+      cy.getByTestid('dropdownLanguage').click();
+      // wati until
+      return cy.get('.dropdown-menu').then($elem => $elem.is(':visible'));
+    });
+
     cy.getByTestid('dropdownLanguageMenu-en_US').click();
     cy.getByTestid('dropdownLanguageMenu-en_US').click();
     cy.get('.alert-success').should('be.visible');
     cy.get('.alert-success').should('be.visible');
     cy.screenshot(`${ssPrefix}-select-en_US`);
     cy.screenshot(`${ssPrefix}-select-en_US`);
@@ -48,8 +50,9 @@ describe('Install', () => {
     cy.getByTestid('btnSubmit').click();
     cy.getByTestid('btnSubmit').click();
 
 
     // Redirects to the root page take a long time (more than 10000ms)
     // Redirects to the root page take a long time (more than 10000ms)
+    cy.getByTestid('grw-pagetree-item-container', { timeout: 20000 }).should('be.visible');
+
     cy.waitUntilSkeletonDisappear();
     cy.waitUntilSkeletonDisappear();
-    cy.getByTestid('grw-pagetree-item-container').should('be.visible');
     cy.screenshot(`${ssPrefix}-installed-redirect-to-root-page`, {
     cy.screenshot(`${ssPrefix}-installed-redirect-to-root-page`, {
       blackout: ['[data-hide-in-vrt=true]']
       blackout: ['[data-hide-in-vrt=true]']
     });
     });

+ 7 - 3
packages/app/test/cypress/integration/30-search/30-search--search.spec.ts

@@ -123,9 +123,13 @@ context('Search all pages', () => {
     cy.get('.search-result-content-body-container').scrollTo('top');
     cy.get('.search-result-content-body-container').scrollTo('top');
     cy.screenshot(`${ssPrefix}4-click-three-dots-menu`, {capture: 'viewport'});
     cy.screenshot(`${ssPrefix}4-click-three-dots-menu`, {capture: 'viewport'});
 
 
-    //Add bookmark
-    cy.getByTestid('add-remove-bookmark-btn').click({force: true});
-    cy.get('.btn-bookmark.active').should('be.visible');
+    // Add bookmark
+    cy.waitUntil(() => {
+      // do
+      cy.getByTestid('add-remove-bookmark-btn').click({force: true});
+      // wati until
+      return cy.get('.btn-bookmark.active').then($elem => $elem.is(':visible'));
+    });
     cy.screenshot(`${ssPrefix}5-add-bookmark`, {capture: 'viewport'});
     cy.screenshot(`${ssPrefix}5-add-bookmark`, {capture: 'viewport'});
 
 
     // Duplicate page
     // Duplicate page

+ 10 - 10
packages/app/test/cypress/integration/50-sidebar/50-sidebar--access-to-side-bar.spec.ts

@@ -53,7 +53,7 @@ describe('Access to sidebar', () => {
             cy.get('.grw-pagetree-open').should('be.visible');
             cy.get('.grw-pagetree-open').should('be.visible');
 
 
             // hide page tree tiems
             // hide page tree tiems
-            cy.get('.grw-pagetree-triangle-btn').eq(0).click();
+            cy.get('.grw-pagetree-triangle-btn').first().click();
 
 
             cy.screenshot(`${ssPrefix}page-tree-2-hide-page-tree-items`);
             cy.screenshot(`${ssPrefix}page-tree-2-hide-page-tree-items`);
           });
           });
@@ -62,7 +62,7 @@ describe('Access to sidebar', () => {
         it('Successfully click Add to Bookmarks button', () => {
         it('Successfully click Add to Bookmarks button', () => {
           // click three dots
           // click three dots
           cy.get('.grw-pagetree-item-children').first().within(() => {
           cy.get('.grw-pagetree-item-children').first().within(() => {
-            cy.getByTestid('open-page-item-control-btn').find('button').eq(0).invoke('css','display','block').click();
+            cy.getByTestid('open-page-item-control-btn').find('button').first().invoke('css','display','block').click();
           });
           });
 
 
           cy.getByTestid('page-item-control-menu').should('have.class', 'show');
           cy.getByTestid('page-item-control-menu').should('have.class', 'show');
@@ -79,7 +79,7 @@ describe('Access to sidebar', () => {
 
 
           // show dropdown again
           // show dropdown again
           cy.get('.grw-pagetree-item-children').first().within(() => {
           cy.get('.grw-pagetree-item-children').first().within(() => {
-            cy.getByTestid('open-page-item-control-btn').find('button').eq(0).invoke('css','display','block').click();
+            cy.getByTestid('open-page-item-control-btn').find('button').first().invoke('css','display','block').click();
           });
           });
 
 
           cy.getByTestid('page-item-control-menu').should('have.class', 'show');
           cy.getByTestid('page-item-control-menu').should('have.class', 'show');
@@ -91,8 +91,8 @@ describe('Access to sidebar', () => {
         });
         });
 
 
         it('Successfully show duplicate page modal', () => {
         it('Successfully show duplicate page modal', () => {
-          cy.get('.grw-pagetree-item-children').eq(0).within(() => {
-            cy.getByTestid('open-page-item-control-btn').find('button').eq(0).invoke('css','display','block').click();
+          cy.get('.grw-pagetree-item-children').first().within(() => {
+            cy.getByTestid('open-page-item-control-btn').find('button').first().invoke('css','display','block').click();
           });
           });
           cy.get('.dropdown-menu.show').should('be.visible').within(() => {
           cy.get('.dropdown-menu.show').should('be.visible').within(() => {
             cy.getByTestid('open-page-duplicate-modal-btn').click();
             cy.getByTestid('open-page-duplicate-modal-btn').click();
@@ -108,13 +108,13 @@ describe('Access to sidebar', () => {
 
 
         it('Successfully rename page', () => {
         it('Successfully rename page', () => {
           cy.getByTestid('grw-contextual-navigation-sub').within(() => {
           cy.getByTestid('grw-contextual-navigation-sub').within(() => {
-            cy.get('.grw-pagetree-item-children').eq(0).within(() => {
-              cy.getByTestid('open-page-item-control-btn').find('button').eq(0).invoke('css','display','block').click()
+            cy.get('.grw-pagetree-item-children').first().within(() => {
+              cy.getByTestid('open-page-item-control-btn').find('button').first().invoke('css','display','block').click()
             });
             });
             cy.get('.dropdown-menu.show').should('be.visible').within(() => {
             cy.get('.dropdown-menu.show').should('be.visible').within(() => {
               cy.getByTestid('open-page-move-rename-modal-btn').click();
               cy.getByTestid('open-page-move-rename-modal-btn').click();
             });
             });
-            cy.get('.grw-pagetree-item-children').eq(0).within(() => {
+            cy.get('.grw-pagetree-item-children').first().within(() => {
               cy.getByTestid('closable-text-input').type('_newname');
               cy.getByTestid('closable-text-input').type('_newname');
             });
             });
 
 
@@ -124,8 +124,8 @@ describe('Access to sidebar', () => {
 
 
         it('Successfully show delete page modal', () => {
         it('Successfully show delete page modal', () => {
           cy.getByTestid('grw-contextual-navigation-sub').within(() => {
           cy.getByTestid('grw-contextual-navigation-sub').within(() => {
-            cy.get('.grw-pagetree-item-children').eq(0).within(() => {
-              cy.getByTestid('open-page-item-control-btn').find('button').eq(0).invoke('css','display','block').click()
+            cy.get('.grw-pagetree-item-children').first().within(() => {
+              cy.getByTestid('open-page-item-control-btn').find('button').first().invoke('css','display','block').click()
             });
             });
             cy.get('.dropdown-menu.show').should('be.visible').within(() => {
             cy.get('.dropdown-menu.show').should('be.visible').within(() => {
               cy.getByTestid('open-page-delete-modal-btn').click();
               cy.getByTestid('open-page-delete-modal-btn').click();