Kaynağa Gözat

BugFix: notification to slack doesn't work when update

Yuki Takei 7 yıl önce
ebeveyn
işleme
a965450bab
1 değiştirilmiş dosya ile 2 ekleme ve 3 silme
  1. 2 3
      src/server/routes/page.js

+ 2 - 3
src/server/routes/page.js

@@ -597,9 +597,6 @@ module.exports = function(crowi, app) {
       options.grantUserGroupId = grantUserGroupId;
       options.grantUserGroupId = grantUserGroupId;
     }
     }
 
 
-    // store previous revision
-    const previousRevision = page.revision;
-
     try {
     try {
       page = await Page.updatePage(page, pageBody, req.user, options);
       page = await Page.updatePage(page, pageBody, req.user, options);
     }
     }
@@ -622,6 +619,8 @@ module.exports = function(crowi, app) {
 
 
     // user notification
     // user notification
     if (isSlackEnabled && slackChannels != null) {
     if (isSlackEnabled && slackChannels != null) {
+      const Revision = crowi.model('Revision');
+      const previousRevision = await Revision.findById(page.revision);
       await notifyToSlackByUser(page, req.user, slackChannels, 'update', previousRevision);
       await notifyToSlackByUser(page, req.user, slackChannels, 'update', previousRevision);
     }
     }
   };
   };