Yuki Takei 6 лет назад
Родитель
Сommit
a336b2ce74
2 измененных файлов с 7 добавлено и 7 удалено
  1. 7 6
      src/server/middleware/safe-redirect.js
  2. 0 1
      src/server/routes/login-passport.js

+ 7 - 6
src/server/middleware/safe-redirect.js

@@ -1,8 +1,13 @@
+/**
+ * Redirect with prevention from Open Redirect
+ *
+ * Usage: app.use(require('middleware/safe-redirect')(['example.com', 'some.example.com:8080']))
+ */
+
 const loggerFactory = require('@alias/logger');
 
 const logger = loggerFactory('growi:middleware:safe-redirect');
 
-
 /**
  * Check whether the redirect url host is in specified whitelist
  * @param {Array<string>} whitelistOfHosts
@@ -17,11 +22,7 @@ function isInWhitelist(whitelistOfHosts, redirectToFqdn) {
   return whitelistOfHosts.includes(redirectUrl.hostname) || whitelistOfHosts.includes(redirectUrl.host);
 }
 
-/**
- * Redirect with prevention from Open Redirect
- *
- * Usage: app.use(require('middleware/safe-redirect'))
- */
+
 module.exports = (whitelistOfHosts) => {
 
   return function(req, res, next) {

+ 0 - 1
src/server/routes/login-passport.js

@@ -4,7 +4,6 @@ module.exports = function(crowi, app) {
   const debug = require('debug')('growi:routes:login-passport');
   const logger = require('@alias/logger')('growi:routes:login-passport');
   const passport = require('passport');
-  const { URL } = require('url');
   const ExternalAccount = crowi.model('ExternalAccount');
   const passportService = crowi.passportService;