fix: rename isHidingUserPages to disableUserPages across the application

apps/app/src/client/components/Admin/Security/SecuritySetting/UserPageVisibilitySettings.tsx

@@ -24,7 +24,7 @@ export const UserPageVisibilitySettings: React.FC<Props> = ({
               type="checkbox"
               className="form-check-input"
               id="is-user-pages-visible"
-              checked={adminGeneralSecurityContainer.state.isHidingUserPages}
+              checked={adminGeneralSecurityContainer.state.disableUserPages}
               onChange={() => {
                 adminGeneralSecurityContainer.changeUserPageVisibility();
               }}

apps/app/src/client/components/Admin/Security/SecuritySetting/index.tsx

@@ -64,8 +64,8 @@ const SecuritySettingComponent: React.FC<Props> = ({
           hideRestrictedByOwner:
             adminGeneralSecurityContainer.state
               .currentOwnerRestrictionDisplayMode === 'Hidden',
-          isHidingUserPages:
-            adminGeneralSecurityContainer.state.isHidingUserPages,
+          disableUserPages:
+            adminGeneralSecurityContainer.state.disableUserPages,
           isUsersHomepageDeletionEnabled:
             adminGeneralSecurityContainer.state.isUsersHomepageDeletionEnabled,
           isForceDeleteUserHomepageOnUserDeletion:

apps/app/src/client/services/AdminGeneralSecurityContainer.js

@@ -45,7 +45,7 @@ export default class AdminGeneralSecurityContainer extends Container {
       expandOtherOptionsForCompleteDeletion: false,
       isShowRestrictedByOwner: false,
       isUsersHomepageDeletionEnabled: false,
-      isHidingUserPages: false,
+      disableUserPages: false,
       isForceDeleteUserHomepageOnUserDeletion: false,
       isRomUserAllowedToComment: false,
       isLocalEnabled: false,
@@ -107,7 +107,7 @@ export default class AdminGeneralSecurityContainer extends Container {
       isForceDeleteUserHomepageOnUserDeletion:
         generalSetting.isForceDeleteUserHomepageOnUserDeletion,
       isRomUserAllowedToComment: generalSetting.isRomUserAllowedToComment,
-      isHidingUserPages: generalSetting.isHidingUserPages,
+      disableUserPages: generalSetting.disableUserPages,
       sessionMaxAge: generalSetting.sessionMaxAge,
       wikiMode: generalSetting.wikiMode,
       disableLinkSharing: shareLinkSetting.disableLinkSharing,
@@ -180,7 +180,7 @@ export default class AdminGeneralSecurityContainer extends Container {
   }
 
   changeUserPageVisibility() {
-    this.setState({ isHidingUserPages: !this.state.isHidingUserPages });
+    this.setState({ disableUserPages: !this.state.disableUserPages });
   }
 
   /**
@@ -291,7 +291,7 @@ export default class AdminGeneralSecurityContainer extends Container {
               formData.isAllGroupMembershipRequiredForPageCompleteDeletion,
             hideRestrictedByGroup: formData.hideRestrictedByGroup,
             hideRestrictedByOwner: formData.hideRestrictedByOwner,
-            isHidingUserPages: formData.isHidingUserPages,
+            disableUserPages: formData.disableUserPages,
             isUsersHomepageDeletionEnabled:
               formData.isUsersHomepageDeletionEnabled,
             isForceDeleteUserHomepageOnUserDeletion:
@@ -314,7 +314,7 @@ export default class AdminGeneralSecurityContainer extends Container {
               this.state.currentGroupRestrictionDisplayMode === 'Hidden',
             hideRestrictedByOwner:
               this.state.currentOwnerRestrictionDisplayMode === 'Hidden',
-            isHidingUserPages: this.state.isHidingUserPages,
+            disableUserPages: this.state.disableUserPages,
             isUsersHomepageDeletionEnabled:
               this.state.isUsersHomepageDeletionEnabled,
             isForceDeleteUserHomepageOnUserDeletion:

apps/app/src/features/search/client/components/PrivateLegacyPages.tsx

@@ -36,7 +36,7 @@ import type { PageMigrationErrorData } from '~/interfaces/websocket';
 import { SocketEventName } from '~/interfaces/websocket';
 import { useIsAdmin } from '~/states/context';
 import { useSearchKeyword, useSetSearchKeyword } from '~/states/search';
-import { isHidingUserPagesAtom } from '~/states/server-configurations';
+import { disableUserPagesAtom } from '~/states/server-configurations';
 import { useGlobalSocket } from '~/states/socket-io';
 import type { ILegacyPrivatePage } from '~/states/ui/modal/private-legacy-pages-migration';
 import { usePrivateLegacyPagesMigrationModalActions } from '~/states/ui/modal/private-legacy-pages-migration';
@@ -270,7 +270,7 @@ const PrivateLegacyPages = (): JSX.Element => {
   const keyword = useSearchKeyword();
   const setSearchKeyword = useSetSearchKeyword('/_private-legacy-pages');
 
-  const isHidingUserPages = useAtomValue(isHidingUserPagesAtom);
+  const disableUserPages = useAtomValue(disableUserPagesAtom);
 
   const [offset, setOffset] = useState<number>(0);
   const [limit, setLimit] = useState<number>(INITIAL_PAGING_SIZE);
@@ -519,7 +519,7 @@ const PrivateLegacyPages = (): JSX.Element => {
   const searchControl = useMemo(() => {
     return (
       <SearchControl
-        isHidingUserPages={isHidingUserPages}
+        disableUserPages={disableUserPages}
         isEnableSort={false}
         isEnableFilter={false}
         initialSearchConditions={{ keyword: initQ, limit: INITIAL_PAGING_SIZE }}
@@ -527,7 +527,7 @@ const PrivateLegacyPages = (): JSX.Element => {
         extraControls={extraControls}
       />
     );
-  }, [searchInvokedHandler, extraControls, isHidingUserPages]);
+  }, [searchInvokedHandler, extraControls, disableUserPages]);
 
   const searchResultListHead = useMemo(() => {
     if (data == null) {

apps/app/src/features/search/client/components/SearchPage/SearchControl.tsx

@@ -12,7 +12,7 @@ import SortControl from './SortControl';
 type Props = {
   isEnableSort: boolean;
   isEnableFilter: boolean;
-  isHidingUserPages: boolean;
+  disableUserPages: boolean;
   initialSearchConditions: Partial<ISearchConditions>;
 
   onSearchInvoked?: (
@@ -30,7 +30,7 @@ const SearchControl = React.memo((props: Props): JSX.Element => {
   const {
     isEnableSort,
     isEnableFilter,
-    isHidingUserPages,
+    disableUserPages,
     initialSearchConditions,
     onSearchInvoked,
     extraControls,
@@ -154,7 +154,7 @@ const SearchControl = React.memo((props: Props): JSX.Element => {
               </button>
             </div>
             <div className="d-none d-lg-flex align-items-center search-control-include-options">
-              {isHidingUserPages === false && (
+              {disableUserPages === false && (
                 <div className="px-2 py-1">
                   <div className="form-check form-check-succsess">
                     <input
@@ -212,7 +212,7 @@ const SearchControl = React.memo((props: Props): JSX.Element => {
       <SearchOptionModalLazyLoaded
         isOpen={isFileterOptionModalShown || false}
         onClose={() => setIsFileterOptionModalShown(false)}
-        isHidingUserPages={isHidingUserPages}
+        disableUserPages={disableUserPages}
         includeUserPages={includeUserPages}
         includeTrashPages={includeTrashPages}
         onIncludeUserPagesSwitched={setIncludeUserPages}

apps/app/src/features/search/client/components/SearchPage/SearchOptionModal/SearchOptionModal.tsx

@@ -6,7 +6,7 @@ type Props = {
   isOpen: boolean;
   includeUserPages: boolean;
   includeTrashPages: boolean;
-  isHidingUserPages: boolean;
+  disableUserPages: boolean;
   onClose?: () => void;
   onIncludeUserPagesSwitched?: (isChecked: boolean) => void;
   onIncludeTrashPagesSwitched?: (isChecked: boolean) => void;
@@ -19,7 +19,7 @@ export const SearchOptionModal: FC<Props> = (props: Props) => {
     isOpen,
     includeUserPages,
     includeTrashPages,
-    isHidingUserPages,
+    disableUserPages,
     onClose,
     onIncludeUserPagesSwitched,
     onIncludeTrashPagesSwitched,
@@ -57,7 +57,7 @@ export const SearchOptionModal: FC<Props> = (props: Props) => {
       </ModalHeader>
       <ModalBody>
         <div className="d-flex p-2">
-          {!isHidingUserPages && (
+          {!disableUserPages && (
             <div className="me-3">
               <label className="form-label px-3 py-2 mb-0 d-flex align-items-center">
                 <input

apps/app/src/features/search/client/components/SearchPage/SearchOptionModal/dynamic.tsx

@@ -6,7 +6,7 @@ type SearchOptionModalProps = {
   isOpen: boolean;
   includeUserPages: boolean;
   includeTrashPages: boolean;
-  isHidingUserPages: boolean;
+  disableUserPages: boolean;
   onClose?: () => void;
   onIncludeUserPagesSwitched?: (isChecked: boolean) => void;
   onIncludeTrashPagesSwitched?: (isChecked: boolean) => void;

apps/app/src/features/search/client/components/SearchPage/SearchPage.tsx

@@ -12,7 +12,7 @@ import type {
 import type { IFormattedSearchResult } from '~/interfaces/search';
 import { useSearchKeyword, useSetSearchKeyword } from '~/states/search';
 import {
-  isHidingUserPagesAtom,
+  disableUserPagesAtom,
   showPageLimitationLAtom,
 } from '~/states/server-configurations';
 import {
@@ -109,7 +109,7 @@ export const SearchPage = (): JSX.Element => {
   const keyword = useSearchKeyword();
   const setSearchKeyword = useSetSearchKeyword();
 
-  const isHidingUserPages = useAtomValue(isHidingUserPagesAtom);
+  const disableUserPages = useAtomValue(disableUserPagesAtom);
 
   const [offset, setOffset] = useState<number>(0);
   const [limit, setLimit] = useState<number>(
@@ -291,7 +291,7 @@ export const SearchPage = (): JSX.Element => {
       <SearchControl
         isEnableSort
         isEnableFilter
-        isHidingUserPages={isHidingUserPages}
+        disableUserPages={disableUserPages}
         initialSearchConditions={initialSearchConditions}
         onSearchInvoked={searchInvokedHandler}
         extraControls={extraControls}
@@ -304,7 +304,7 @@ export const SearchPage = (): JSX.Element => {
     collapseContents,
     initialSearchConditions,
     isCollapsed,
-    isHidingUserPages,
+    disableUserPages,
     searchInvokedHandler,
   ]);
 

apps/app/src/pages/[[...path]]/page-data-props.ts

@@ -164,11 +164,11 @@ export async function getPageDataForInitial(
     { pageId, path: resolvedPagePath, user },
   );
 
-  const isHidingUserPages = configManager.getConfig(
-    'security:isHidingUserPages',
+  const disableUserPages = configManager.getConfig(
+    'security:disable-user-pages',
   );
 
-  if (isHidingUserPages && pageWithMeta.data != null) {
+  if (disableUserPages && pageWithMeta.data != null) {
     const pagePath = pageWithMeta.data.path;
     const isTargetUserPage = isUserPage(pagePath) || isUsersTopPage(pagePath);
 

apps/app/src/pages/_search/get-server-side-props/index.ts

@@ -31,8 +31,8 @@ const getServerSideConfigurationProps: GetServerSideProps<
         showPageLimitationL: configManager.getConfig(
           'customize:showPageLimitationL',
         ),
-        isHidingUserPages: configManager.getConfig(
-          'security:isHidingUserPages',
+        disableUserPages: configManager.getConfig(
+          'security:disable-user-pages',
         ),
       },
     },

apps/app/src/pages/_search/types.ts

@@ -2,6 +2,6 @@ export type ServerConfigurationProps = {
   serverConfig: {
     isContainerFluid: boolean;
     showPageLimitationL: number;
-    isHidingUserPages: boolean;
+    disableUserPages: boolean;
   };
 };

apps/app/src/pages/_search/use-hydrate-server-configurations.ts

@@ -2,8 +2,8 @@ import { useHydrateAtoms } from 'jotai/utils';
 
 import type { RendererConfig } from '~/interfaces/services/renderer';
 import {
+  disableUserPagesAtom,
   isContainerFluidAtom,
-  isHidingUserPagesAtom,
   rendererConfigAtom,
   showPageLimitationLAtom,
 } from '~/states/server-configurations';
@@ -26,7 +26,7 @@ export const useHydrateServerConfigurationAtoms = (
           [isContainerFluidAtom, serverConfig.isContainerFluid],
           [showPageLimitationLAtom, serverConfig.showPageLimitationL],
           [rendererConfigAtom, rendererConfigs],
-          [isHidingUserPagesAtom, serverConfig.isHidingUserPages],
+          [disableUserPagesAtom, serverConfig.disableUserPages],
         ],
   );
 };

apps/app/src/pages/general-page/configuration-props.ts

@@ -120,8 +120,8 @@ export const getServerSideGeneralPageProps: GetServerSideProps<
         isEnabledAttachTitleHeader: configManager.getConfig(
           'customize:isEnabledAttachTitleHeader',
         ),
-        isHidingUserPages: configManager.getConfig(
-          'security:isHidingUserPages',
+        disableUserPages: configManager.getConfig(
+          'security:disable-user-pages',
         ),
       },
     },

apps/app/src/pages/general-page/hydrate.ts

@@ -5,6 +5,7 @@ import {
   aiEnabledAtom,
   defaultIndentSizeAtom,
   disableLinkSharingAtom,
+  disableUserPagesAtom,
   drawioUriAtom,
   elasticsearchMaxBodyLengthToIndexAtom,
   isAclEnabledAtom,
@@ -13,7 +14,6 @@ import {
   isContainerFluidAtom,
   isEnabledAttachTitleHeaderAtom,
   isEnabledStaleNotificationAtom,
-  isHidingUserPagesAtom,
   isIndentSizeForcedAtom,
   isLocalAccountRegistrationEnabledAtom,
   isPdfBulkExportEnabledAtom,
@@ -85,7 +85,7 @@ export const useHydrateGeneralPageConfigurationAtoms = (
             serverConfig.isLocalAccountRegistrationEnabled,
           ],
           [rendererConfigAtom, rendererConfigs],
-          [isHidingUserPagesAtom, serverConfig.isHidingUserPages],
+          [disableUserPagesAtom, serverConfig.disableUserPages],
         ],
   );
 };

apps/app/src/pages/general-page/types.ts

@@ -32,7 +32,7 @@ export type ServerConfigurationProps = {
     isEnabledStaleNotification: boolean;
     disableLinkSharing: boolean;
     isIndentSizeForced: boolean;
-    isHidingUserPages: boolean;
+    disableUserPages: boolean;
     isEnabledAttachTitleHeader: boolean;
     isSlackConfigured: boolean;
     isAclEnabled: boolean;

apps/app/src/server/models/page.ts

@@ -89,7 +89,7 @@ export type FindRecentUpdatedPagesOption = {
   desc: number;
   hideRestrictedByOwner: boolean;
   hideRestrictedByGroup: boolean;
-  hideUserPages: boolean;
+  disableUserPages: boolean;
 };
 
 export type CreateMethod = (
@@ -937,7 +937,7 @@ schema.statics.findRecentUpdatedPages = async function (
   const baseQuery = this.find({});
   const queryBuilder = new PageQueryBuilder(baseQuery, includeEmpty);
 
-  if (options.hideUserPages) {
+  if (options.disableUserPages) {
     queryBuilder.addConditionToListByNotMatchPathAndChildren('/user');
   }
 

apps/app/src/server/routes/apiv3/bookmarks.ts

@@ -257,11 +257,11 @@ module.exports = (crowi) => {
           })
           .exec();
 
-        const isHidingUserPages = configManager.getConfig(
-          'security:isHidingUserPages',
+        const disabledUserPage = configManager.getConfig(
+          'security:disable-user-pages',
         );
 
-        const filteredBookmarks = isHidingUserPages
+        const filteredBookmarks = disabledUserPage
           ? userRootBookmarks.filter(
               (bookmark) =>
                 bookmark.page != null &&

apps/app/src/server/routes/apiv3/page-listing.ts

@@ -159,8 +159,8 @@ const routerFactory = (crowi: Crowi): Router => {
       const hideRestrictedByGroup = await configManager.getConfig(
         'security:list-policy:hideRestrictedByGroup',
       );
-      const hideUserPages = await configManager.getConfig(
-        'security:isHidingUserPages',
+      const disableUserPages = await configManager.getConfig(
+        'security:disable-user-pages',
       );
 
       try {
@@ -172,7 +172,7 @@ const routerFactory = (crowi: Crowi): Router => {
             !hideRestrictedByGroup,
           );
 
-        if (hideUserPages === true) {
+        if (disableUserPages) {
           pages = pages.filter(
             (page) => !isUserPage(page.path) && !isUsersTopPage(page.path),
           );

apps/app/src/server/routes/apiv3/page/index.ts

@@ -197,8 +197,8 @@ module.exports = (crowi: Crowi) => {
       const { pageId, path, findAll, revisionId, shareLinkId, includeEmpty } =
         req.query;
 
-      const isHidingUserPages = crowi.configManager.getConfig(
-        'security:isHidingUserPages',
+      const disableUserPages = crowi.configManager.getConfig(
+        'security:disable-user-pages',
       );
 
       const respondWithSinglePage = async (
@@ -227,7 +227,7 @@ module.exports = (crowi: Crowi) => {
           );
         }
 
-        if (isHidingUserPages && page != null) {
+        if (disableUserPages && page != null) {
           const isTargetUserPage =
             isUserPage(page.path) || isUsersTopPage(page.path);
 

apps/app/src/server/routes/apiv3/pages/index.js

@@ -193,8 +193,8 @@ module.exports = (crowi) => {
       const hideRestrictedByGroup = configManager.getConfig(
         'security:list-policy:hideRestrictedByGroup',
       );
-      const hideUserPages = configManager.getConfig(
-        'security:isHidingUserPages',
+      const disableUserPages = configManager.getConfig(
+        'security:disable-user-pages',
       );
 
       /**
@@ -210,7 +210,7 @@ module.exports = (crowi) => {
         desc: -1,
         hideRestrictedByOwner,
         hideRestrictedByGroup,
-        hideUserPages,
+        disableUserPages,
       };
 
       try {

apps/app/src/server/routes/apiv3/security-settings/index.js

@@ -47,7 +47,7 @@ const validator = {
     body('hideRestrictedByGroup')
       .if((value) => value != null)
       .isBoolean(),
-    body('isHidingUserPages')
+    body('disableUserPages')
       .if((value) => value != null)
       .isBoolean(),
     body('isUsersHomepageDeletionEnabled')
@@ -220,7 +220,7 @@ const validator = {
  *          pageCompleteDeletionAuthority:
  *            type: string
  *            description: type of pageDeletionAuthority
- *          isHidingUserPages:
+ *          disableUserPages:
  *            type: boolean
  *            description: hide all user pages from general users
  *          hideRestrictedByOwner:
@@ -511,8 +511,8 @@ module.exports = (crowi) => {
           hideRestrictedByGroup: await configManager.getConfig(
             'security:list-policy:hideRestrictedByGroup',
           ),
-          isHidingUserPages: await configManager.getConfig(
-            'security:isHidingUserPages',
+          disableUserPages: await configManager.getConfig(
+            'security:disable-user-pages',
           ),
           isUsersHomepageDeletionEnabled: await configManager.getConfig(
             'security:user-homepage-deletion:isEnabled',
@@ -1004,7 +1004,7 @@ module.exports = (crowi) => {
           req.body.hideRestrictedByOwner,
         'security:list-policy:hideRestrictedByGroup':
           req.body.hideRestrictedByGroup,
-        'security:isHidingUserPages': req.body.isHidingUserPages,
+        'security:disable-user-pages': req.body.disableUserPages,
         'security:user-homepage-deletion:isEnabled':
           req.body.isUsersHomepageDeletionEnabled,
         // Validate user-homepage-deletion config
@@ -1077,8 +1077,8 @@ module.exports = (crowi) => {
           hideRestrictedByGroup: await configManager.getConfig(
             'security:list-policy:hideRestrictedByGroup',
           ),
-          isHidingUserPages: await configManager.getConfig(
-            'security:isHidingUserPages',
+          disableUserPages: await configManager.getConfig(
+            'security:disable-user-pages',
           ),
           isUsersHomepageDeletionEnabled: await configManager.getConfig(
             'security:user-homepage-deletion:isEnabled',

apps/app/src/server/service/config-manager/config-definition.ts

@@ -115,7 +115,7 @@ export const CONFIG_KEYS = [
   'security:pageRecursiveDeletionAuthority',
   'security:pageRecursiveCompleteDeletionAuthority',
   'security:isAllGroupMembershipRequiredForPageCompleteDeletion',
-  'security:isHidingUserPages',
+  'security:disable-user-pages',
   'security:user-homepage-deletion:isEnabled',
   'security:user-homepage-deletion:isForceDeleteUserHomepageOnUserDeletion',
   'security:isRomUserAllowedToComment',
@@ -679,7 +679,7 @@ export const CONFIG_DEFINITIONS = {
     defineConfig<boolean>({
       defaultValue: true,
     }),
-  'security:isHidingUserPages': defineConfig<boolean>({
+  'security:disable-user-pages': defineConfig<boolean>({
     defaultValue: false,
   }),
   'security:user-homepage-deletion:isEnabled': defineConfig<boolean>({

apps/app/src/server/service/page/index.ts

@@ -799,7 +799,7 @@ class PageService implements IPageService {
   getExcludedPathsBySystem(): string[] {
     const excludedPaths: string[] = [];
 
-    if (configManager.getConfig('security:isHidingUserPages')) {
+    if (configManager.getConfig('security:disable-user-pages')) {
       excludedPaths.push('/user');
     }
 

apps/app/src/states/server-configurations/server-configurations.ts

@@ -146,7 +146,7 @@ export const isPdfBulkExportEnabledAtom = atom<boolean>(false);
 /**
  * Atom for hiding user pages setting enabled
  */
-export const isHidingUserPagesAtom = atom<boolean>(false);
+export const disableUserPagesAtom = atom<boolean>(false);
 
 /**
  * Atom for local account registration enabled