Răsfoiți Sursa

fix dom structure

Yuki Takei 2 ani în urmă
părinte
comite
9b13fa0913

+ 16 - 31
apps/app/src/components/Sidebar/Sidebar.module.scss

@@ -2,28 +2,13 @@
 @use '@growi/core/scss/bootstrap/init' as bs;
 @use '@growi/core/scss/bootstrap/init' as bs;
 
 
 .grw-sidebar :global {
 .grw-sidebar :global {
-  // sticky
-  position: sticky;
-  top: 0;
-
-  // set the max value that should be taken when sticky
-  height: 100vh;
-
   border-right : 1px solid var(--bs-border-color);
   border-right : 1px solid var(--bs-border-color);
 
 
-  .data-layout-container {
+  .grw-navigation-wrap {
     display: flex;
     display: flex;
     flex-direction: row;
     flex-direction: row;
-    height: 100vh;
-    margin-top: 0px;
-  }
-  .navigation {
-    .grw-navigation-wrap {
-      display: flex;
-      flex-direction: row;
-      height: 100%;
-      overflow: hidden;
-    }
+    height: 100%;
+    overflow: hidden;
   }
   }
 
 
   .grw-sidebar-content-header {
   .grw-sidebar-content-header {
@@ -36,18 +21,23 @@
 
 
 // Dock Mode
 // Dock Mode
 @mixin dock() {
 @mixin dock() {
+  .grw-navigation-wrap {
+    // sticky
+    position: sticky;
+    top: 0;
+
+    // set the max value that should be taken when sticky
+    height: 100vh;
+  }
 }
 }
 
 
 // Drawer Mode
 // Drawer Mode
 @mixin drawer() {
 @mixin drawer() {
-  z-index: bs.$zindex-fixed + 2;
 
 
-  .data-layout-container {
+  .grw-navigation-wrap {
     position: fixed;
     position: fixed;
     top: 0;
     top: 0;
-    width: 0;
-  }
-  div.navigation.transition-enabled {
+    z-index: bs.$zindex-fixed + 2;
     max-width: 80vw;
     max-width: 80vw;
 
 
     // apply transition
     // apply transition
@@ -56,12 +46,12 @@
   }
   }
 
 
   &:not(.open) {
   &:not(.open) {
-    div.navigation {
+    .grw-navigation-wrap {
       transform: translateX(-100%);
       transform: translateX(-100%);
     }
     }
   }
   }
   &.open {
   &.open {
-    div.navigation {
+    .grw-navigation-wrap {
       transform: translateX(0);
       transform: translateX(0);
     }
     }
   }
   }
@@ -73,12 +63,7 @@
       @include drawer();
       @include drawer();
     }
     }
     &.grw-sidebar-dock {
     &.grw-sidebar-dock {
-      @include bs.media-breakpoint-down(sm) {
-        @include drawer();
-      }
-      @include bs.media-breakpoint-up(md) {
-        @include dock();
-      }
+      @include dock();
     }
     }
   }
   }
 }
 }

+ 13 - 17
apps/app/src/components/Sidebar/Sidebar.tsx

@@ -89,24 +89,20 @@ export const SidebarSubstance = memo((): JSX.Element => {
   const disableResizing = isResizeDisabled || isDrawerMode || isCollapsed;
   const disableResizing = isResizeDisabled || isDrawerMode || isCollapsed;
 
 
   return (
   return (
-    <div className="data-layout-container">
-      <div className="navigation transition-enabled">
-        <div className="grw-navigation-wrap">
-          <SidebarNav />
-          <ResizableArea
-            width={resizableAreaWidth}
-            minWidth={sidebarMinWidth}
-            disabled={disableResizing}
-            onResize={resizeHandler}
-            onResizeDone={resizeDoneHandler}
-            onCollapsed={collapsedByResizableAreaHandler}
-          >
-            <div className="sidebar-contents-container">
-              <SidebarContents />
-            </div>
-          </ResizableArea>
+    <div className="grw-navigation-wrap">
+      <SidebarNav />
+      <ResizableArea
+        width={resizableAreaWidth}
+        minWidth={sidebarMinWidth}
+        disabled={disableResizing}
+        onResize={resizeHandler}
+        onResizeDone={resizeDoneHandler}
+        onCollapsed={collapsedByResizableAreaHandler}
+      >
+        <div className="sidebar-contents-container">
+          <SidebarContents />
         </div>
         </div>
-      </div>
+      </ResizableArea>
     </div>
     </div>
   );
   );