zahmis 5 лет назад
Родитель
Сommit
9ae0e8c94d
1 измененных файлов с 7 добавлено и 5 удалено
  1. 7 5
      src/client/js/components/PageDuplicateModal.jsx

+ 7 - 5
src/client/js/components/PageDuplicateModal.jsx

@@ -1,4 +1,4 @@
-import React, { useState, useEffect } from 'react';
+import React, { useState, useEffect, useCallback } from 'react';
 import PropTypes from 'prop-types';
 import PropTypes from 'prop-types';
 
 
 import {
 import {
@@ -50,7 +50,7 @@ const PageDuplicateModal = (props) => {
     setIsDuplicateRecursively(!isDuplicateRecursively);
     setIsDuplicateRecursively(!isDuplicateRecursively);
   }
   }
 
 
-  async function getSubordinatedList() {
+  const getSubordinatedList = useCallback(async() => {
     try {
     try {
       const res = await appContainer.apiv3Get('/pages/subordinated-list', { path });
       const res = await appContainer.apiv3Get('/pages/subordinated-list', { path });
       setSubordinatedPaths(res.data.resultPaths);
       setSubordinatedPaths(res.data.resultPaths);
@@ -58,11 +58,13 @@ const PageDuplicateModal = (props) => {
     catch (err) {
     catch (err) {
       setGetSuborinatedError(t('modal_duplicate.label.Fail to get subordinated pages'));
       setGetSuborinatedError(t('modal_duplicate.label.Fail to get subordinated pages'));
     }
     }
-  }
+  }, [appContainer, path, t]);
 
 
   useEffect(() => {
   useEffect(() => {
-    getSubordinatedList();
-  }, [props.isOpen]);
+    if (props.isOpen === true) {
+      getSubordinatedList();
+    }
+  }, [props.isOpen, getSubordinatedList]);
 
 
   async function duplicate() {
   async function duplicate() {
     try {
     try {