Browse Source

FB2: simplify Invalid URL constructor

kaori 4 years ago
parent
commit
9ac7f7fde2

+ 1 - 2
packages/slackbot-proxy/src/controllers/slack.ts

@@ -185,7 +185,6 @@ export class SlackCtrl {
 
     const payload = JSON.parse(body.payload);
     const callBackId = payload?.view?.callback_id;
-    const growiUrl = payload.view.state.values.growiUrl.contents_input.value;
 
     // register
     if (callBackId === 'register') {
@@ -194,7 +193,7 @@ export class SlackCtrl {
       }
       catch (err) {
         if (err instanceof InvalidUrlError) {
-          logger.info(err.message, err.url);
+          logger.info(err.message);
           return;
         }
         logger.error(err);

+ 1 - 6
packages/slackbot-proxy/src/models/errors.ts

@@ -2,13 +2,8 @@ import ExtensibleCustomError from 'extensible-custom-error';
 
 export class InvalidUrlError extends ExtensibleCustomError {
 
-  public url: string;
-
   constructor(url: string) {
-    super();
-
-    this.url = url;
-    this.message = 'Invalid URL';
+    super(`Invalid URL: ${url}`);
   }
 
 }

+ 1 - 1
packages/slackbot-proxy/src/services/RegisterService.ts

@@ -76,7 +76,7 @@ export class RegisterService implements GrowiCommandProcessor {
         ],
       });
 
-      throw new InvalidUrlError(`'${growiUrl}' is an invalid URL`);
+      throw new InvalidUrlError(growiUrl);
     }
 
     orderRepository.save({