Procházet zdrojové kódy

Merge pull request #10640 from growilabs/imrpv/176290-enhancing-of-i18n-settings-for-same-routing

imprv: Performance improvements for i18n settings during same routing
Yuki Takei před 3 měsíci
rodič
revize
91e385e982

+ 0 - 2
apps/app/src/pages/[[...path]]/server-side-props.ts

@@ -169,8 +169,6 @@ export async function getServerSidePropsForInitial(
 export async function getServerSidePropsForSameRoute(
   context: GetServerSidePropsContext,
 ): Promise<GetServerSidePropsResult<Stage2EachProps>> {
-  // -- TODO: :https://redmine.weseek.co.jp/issues/174725
-  // Remove getServerSideI18nProps from getServerSidePropsForSameRoute for performance improvement
   const [i18nPropsResult, pageDataForSameRouteResult] = await Promise.all([
     getServerSideI18nProps(context, ['translation']),
     getPageDataForSameRoute(context),

+ 3 - 7
apps/app/src/pages/common-props/i18n.ts

@@ -1,6 +1,9 @@
 import type { GetServerSidePropsContext, GetServerSidePropsResult } from 'next';
 import { AllLang } from '@growi/core';
 import type { SSRConfig } from 'next-i18next';
+import { serverSideTranslations } from 'next-i18next/serverSideTranslations';
+
+import nextI18NextConfig from '^/config/next-i18next.config';
 
 import type { CrowiRequest } from '~/interfaces/crowi-request';
 import { getLangAtServerSide } from '~/pages/utils/locale';
@@ -11,13 +14,6 @@ async function createNextI18NextConfig(
   namespacesRequired?: string[],
   preloadAllLang = false,
 ): Promise<SSRConfig> {
-  const { serverSideTranslations } = await import(
-    'next-i18next/serverSideTranslations'
-  );
-
-  // Import configuration to fix the error
-  const nextI18NextConfig = await import('^/config/next-i18next.config');
-
   // Determine language from request context
   const req: CrowiRequest = context.req as CrowiRequest;
   const lang = getLangAtServerSide(req);