Browse Source

rename fireForPage from fire

itizawa 5 năm trước cách đây
mục cha
commit
859d50fb90

+ 1 - 1
src/server/routes/apiv3/pages.js

@@ -252,7 +252,7 @@ module.exports = (crowi) => {
     // user notification
     if (isSlackEnabled) {
       try {
-        const results = await userNotificationService.fire(createdPage, req.user, slackChannels, 'create', false);
+        const results = await userNotificationService.fireForPage(createdPage, req.user, slackChannels, 'create', false);
         results.forEach((result) => {
           if (result.status === 'rejected') {
             logger.error('Create user notification failed', result.reason);

+ 2 - 2
src/server/routes/page.js

@@ -723,7 +723,7 @@ module.exports = function(crowi, app) {
     // user notification
     if (isSlackEnabled) {
       try {
-        const results = await userNotificationService.fire(createdPage, req.user, slackChannels, 'create');
+        const results = await userNotificationService.fireForPage(createdPage, req.user, slackChannels, 'create');
         results.forEach((result) => {
           if (result.status === 'rejected') {
             logger.error('Create user notification failed', result.reason);
@@ -868,7 +868,7 @@ module.exports = function(crowi, app) {
     // user notification
     if (isSlackEnabled) {
       try {
-        const results = await userNotificationService.fire(page, req.user, slackChannels, 'update', previousRevision);
+        const results = await userNotificationService.fireForPage(page, req.user, slackChannels, 'update', previousRevision);
         results.forEach((result) => {
           if (result.status === 'rejected') {
             logger.error('Create user notification failed', result.reason);

+ 2 - 2
src/server/service/user-notification/index.js

@@ -12,7 +12,7 @@ class UserNotificationService {
   }
 
   /**
-   * fire user notification
+   * fire user notification for page
    *
    * @memberof UserNotificationService
    *
@@ -22,7 +22,7 @@ class UserNotificationService {
    * @param {string} updateOrCreate 'create' or 'update'
    * @param {string} previousRevision
    */
-  async fire(page, user, slackChannelsStr, updateOrCreate, previousRevision = '') {
+  async fireForPage(page, user, slackChannelsStr, updateOrCreate, previousRevision = '') {
     const { slackNotificationService, slack } = this.crowi;
 
     await page.updateSlackChannels(slackChannelsStr);