Просмотр исходного кода

remove PLUGIN_NAMES_TOBE_LOADED

Yuki Takei 4 лет назад
Родитель
Сommit
853d4c4f94
3 измененных файлов с 1 добавлено и 41 удалено
  1. 1 17
      bin/generate-plugin-definitions-source.js
  2. 0 5
      config/env.dev.js
  3. 0 19
      src/server/plugins/plugin.service.js

+ 1 - 17
bin/generate-plugin-definitions-source.js

@@ -20,25 +20,9 @@ const OUT = helpers.root('tmp/plugins/plugin-definitions.js');
 
 
 // list plugin names
-let pluginNames = pluginUtils.listPluginNames(helpers.root());
+const pluginNames = pluginUtils.listPluginNames(helpers.root());
 logger.info('Detected plugins: ', pluginNames);
 
-// add from PLUGIN_NAMES_TOBE_LOADED when development
-if (process.env.NODE_ENV === 'development'
-    && process.env.PLUGIN_NAMES_TOBE_LOADED !== undefined
-    && process.env.PLUGIN_NAMES_TOBE_LOADED.length > 0) {
-  const pluginNamesDev = process.env.PLUGIN_NAMES_TOBE_LOADED.split(',');
-
-  logger.info('Detected plugins from PLUGIN_NAMES_TOBE_LOADED: ', pluginNamesDev);
-
-  // merge and remove duplicates
-  if (pluginNamesDev.length > 0) {
-    pluginNames = pluginNames.concat(pluginNamesDev);
-    pluginNames = Array.from(new Set(pluginNames));
-  }
-}
-
-
 // get definitions
 const definitions = pluginNames
   .map((name) => {

+ 0 - 5
config/env.dev.js

@@ -12,11 +12,6 @@ module.exports = {
   HACKMD_URI_FOR_SERVER: 'http://hackmd:3000',
   // DRAWIO_URI: 'http://localhost:8080/?offline=1&https=0',
   // S2SMSG_PUBSUB_SERVER_TYPE: 'nchan',
-  PLUGIN_NAMES_TOBE_LOADED: [
-    // 'growi-plugin-lsx',
-    // 'growi-plugin-pukiwiki-like-linker',
-    // 'growi-plugin-attachment-refs',
-  ],
   // PUBLISH_OPEN_API: true,
   // USER_UPPER_LIMIT: 0,
   // DEV_HTTPS: true,

+ 0 - 19
src/server/plugins/plugin.service.js

@@ -16,29 +16,10 @@ class PluginService {
     if (isEnabledPlugins) {
       logger.debug('Plugins are enabled');
       this.loadPlugins(this.pluginUtils.listPluginNames(this.crowi.rootDir));
-
-      // when dev
-      if (this.crowi.node_env === 'development') {
-        this.autoDetectAndLoadPluginsForDev();
-      }
     }
 
   }
 
-  autoDetectAndLoadPluginsForDev() {
-    if (process.env.PLUGIN_NAMES_TOBE_LOADED !== undefined
-      && process.env.PLUGIN_NAMES_TOBE_LOADED.length > 0) {
-
-      const pluginNames = process.env.PLUGIN_NAMES_TOBE_LOADED.split(',');
-      logger.debug('[development] loading Plugins', pluginNames);
-
-      // merge and remove duplicates
-      if (pluginNames.length > 0) {
-        this.crowi.pluginService.loadPlugins(pluginNames);
-      }
-    }
-  }
-
   /**
    * load plugins
    *