Răsfoiți Sursa

depopulate revisions when messaging

Yuki Takei 5 ani în urmă
părinte
comite
7ede9bfefb

+ 6 - 3
src/server/models/serializers/page-serializer.js

@@ -25,7 +25,7 @@ function serializeInsecureUserAttributes(page) {
   return page;
 }
 
-function serializePageSecurely(page) {
+function serializePageSecurely(page, shouldDepopulateRevisions = false) {
   let serialized = page;
 
   // invoke toObject if page is a model instance
@@ -33,8 +33,11 @@ function serializePageSecurely(page) {
     serialized = page.toObject();
   }
 
-  // TODO: consider depopulate
-  // depopulateRevisions(serialized);
+  // optional depopulation
+  if (shouldDepopulateRevisions) {
+    depopulateRevisions(serialized);
+  }
+
   serializeInsecureUserAttributes(serialized);
 
   return serialized;

+ 1 - 1
src/server/models/vo/s2c-message.js

@@ -6,7 +6,7 @@ const { serializePageSecurely } = require('../serializers/page-serializer');
 class S2cMessagePageUpdated {
 
   constructor(page, user) {
-    const serializedPage = serializePageSecurely(page);
+    const serializedPage = serializePageSecurely(page, true);
 
     const {
       _id, revision, revisionHackmdSynced, hasDraftOnHackmd,