Explorar o código

Refactor createAttachment to ensure temporary file cleanup occurs after attached handlers complete

Shun Miyazawa hai 10 meses
pai
achega
7b3aed3f11
Modificáronse 1 ficheiros con 2 adicións e 3 borrados
  1. 2 3
      apps/app/src/server/service/attachment.js

+ 2 - 3
apps/app/src/server/service/attachment.js

@@ -60,9 +60,8 @@ class AttachmentService {
       });
 
       // Do not await, run in background
-      Promise.all(attachedHandlerPromises).then(() => {
-        disposeTmpFileCallback?.(file);
-      });
+      Promise.all(attachedHandlerPromises)
+        .finally(disposeTmpFileCallback?.(file));
     }
     catch (err) {
       logger.error('Error while creating attachment', err);