Просмотр исходного кода

use useCallback and clean code

kaori 4 лет назад
Родитель
Сommit
7a4b5a2fd0

+ 3 - 4
packages/app/src/components/Navbar/GrowiContextualSubNavigation.tsx

@@ -190,7 +190,7 @@ const GrowiContextualSubNavigation = (props) => {
     openRenameModal(pageId, revisionId, path);
   }, [openRenameModal]);
 
-  const onDeletedHandler: OnDeletedFunction = (pathOrPathsToDelete, isRecursively, isCompletely) => {
+  const onDeletedHandler: OnDeletedFunction = useCallback((pathOrPathsToDelete, isRecursively, isCompletely) => {
     if (typeof pathOrPathsToDelete !== 'string') {
       return;
     }
@@ -216,12 +216,11 @@ const GrowiContextualSubNavigation = (props) => {
         toastSuccess(t('deleted_single_page', { path }));
       }
     }
-  };
+  }, [mutateChildren, t]);
 
   const deleteItemClickedHandler = useCallback(async(pageToDelete, isAbleToDeleteCompletely) => {
     openDeleteModal([pageToDelete], onDeletedHandler, isAbleToDeleteCompletely);
-    console.log('isAbleToDeleteCompletely_contextual', isAbleToDeleteCompletely);
-  }, [openDeleteModal]);
+  }, [onDeletedHandler, openDeleteModal]);
 
   const templateMenuItemClickHandler = useCallback(() => {
     setIsPageTempleteModalShown(true);