Merge pull request #4243 from weseek/fix/test-for-rename

fix: test for rename page recursively

packages/app/src/test/service/page.test.js

@@ -305,18 +305,27 @@ describe('PageService', () => {
     });
 
     test('rename page with different tree with isRecursively [shallower]', async() => {
+      // setup
+      expect(await Page.findOne({ path: '/level1' })).toBeNull();
+      expect(await Page.findOne({ path: '/level1/level2' })).not.toBeNull();
+      expect(await Page.findOne({ path: '/level1/level2/child' })).not.toBeNull();
+      expect(await Page.findOne({ path: '/level1/level2/level2' })).not.toBeNull();
+      expect(await Page.findOne({ path: '/level1-2021H1' })).not.toBeNull();
+
+      // when
+      //   rename /level1/level2 --> /level1
       await crowi.pageService.renamePage(parentForRename7, '/level1', testUser1, {}, true);
-      const expectPage1 = await Page.findOne({ path: '/level1' });
-      const expectPage2 = await Page.findOne({ path: '/level1/child' });
-      const expectPage3 = await Page.findOne({ path: '/level1/level2/level2' });
-      const expectPage4 = await Page.findOne({ path: '/level1-2021H1' });
 
-      expect(expectPage1).not.toBeNull();
-      expect(expectPage2).not.toBeNull();
-      expect(expectPage3).not.toBeNull();
+      // then
+      expect(await Page.findOne({ path: '/level1' })).not.toBeNull();
+      expect(await Page.findOne({ path: '/level1/child' })).not.toBeNull();
+      expect(await Page.findOne({ path: '/level1/level2' })).toBeNull();
+      expect(await Page.findOne({ path: '/level1/level2/child' })).toBeNull();
+      // The changed path is duplicated with the existing path (/level1/level2), so it will not be changed
+      expect(await Page.findOne({ path: '/level1/level2/level2' })).not.toBeNull();
 
       // Check that pages that are not to be renamed have not been renamed
-      expect(expectPage4).not.toBeNull();
+      expect(await Page.findOne({ path: '/level1-2021H1' })).not.toBeNull();
     });
   });