clean code

lib/routes/login-passport.js

@@ -52,7 +52,7 @@ module.exports = function(crowi, app) {
     }
 
     passport.authenticate('local', (err, user, info) => {
-      debug('---authentication with passport start---');
+      debug('---authentication with LocalStrategy start---');
       debug('user', user);
       debug('info', info);
 
@@ -66,7 +66,7 @@ module.exports = function(crowi, app) {
         return loginSuccess(req, res, user);
       });
 
-      debug('---authentication with passport end---');
+      debug('---authentication with LocalStrategy end---');
     })(req, res, next);
   }
 

lib/service/passport.js

@@ -1,4 +1,4 @@
-const debug = require('debug')('crowi:PassportService');
+const debug = require('debug')('crowi:service:PassportService');
 const passport = require('passport');
 const LocalStrategy = require('passport-local').Strategy;
 
@@ -7,6 +7,10 @@ const LocalStrategy = require('passport-local').Strategy;
  */
 class PassportService {
 
+  // see '/lib/form/login.js'
+  static get USERNAME_FIELD() { return 'loginForm[username]' }
+  static get PASSWORD_FIELD() { return 'loginForm[password]' }
+
   constructor(crowi) {
     this.crowi = crowi;
   }
@@ -21,9 +25,8 @@ class PassportService {
 
     passport.use(new LocalStrategy(
       {
-        // see '/lib/form/login.js'
-        usernameField: 'loginForm[username]',
-        passwordField: 'loginForm[password]'
+        usernameField: PassportService.USERNAME_FIELD,
+        passwordField: PassportService.PASSWORD_FIELD,
       },
       (username, password, done) => {
         // find user