FB

packages/slackbot-proxy/src/controllers/growi-to-slack.ts

@@ -179,13 +179,10 @@ export class GrowiToSlackCtrl {
           return;
         }
         parsedBlock.elements.forEach((element) => {
-          Object.values(DelegatorTypes).forEach((type) => {
-            const growiUriInjector = growiUriInjectorFactory[type]();
-
-            if (growiUriInjector.handleInject(element.type)) {
-              growiUriInjector.inject(element, growiUri);
-            }
-          });
+          const growiUriInjector = growiUriInjectorFactory[element.type]();
+          if (growiUriInjector != null) {
+            growiUriInjector.inject(element, growiUri);
+          }
         });
 
         return;

packages/slackbot-proxy/src/services/growi-uri-injector/GrowiUriInjectionButtonDelegator.ts

@@ -1,9 +1,8 @@
-/* eslint-disable @typescript-eslint/explicit-module-boundary-types */
 import { GrowiUriInjector } from './GrowiUriInjector';
 
 export class GrowiUriInjectionButtonDelegator implements GrowiUriInjector {
 
-  handleInject(type:string) {
+  handleInject(type:string):boolean {
     return type === 'button';
   }
 
@@ -13,7 +12,7 @@ export class GrowiUriInjectionButtonDelegator implements GrowiUriInjector {
     element.value = JSON.stringify({ growiUri, originalData });
   }
 
-  extract(action: any): {growiUri?:string, originalData:any} {
+  extract(action: {value:string}): {growiUri?:string, originalData:any} {
     const parsedValues = JSON.parse(action.value);
     if (parsedValues.originalData != null) {
       parsedValues.originalData = JSON.parse(parsedValues.originalData);