Просмотр исходного кода

fix non-autofixable biome errors

Futa Arai 5 месяцев назад
Родитель
Сommit
7731a5827e

+ 19 - 3
apps/app/src/components/PageView/PageView.tsx

@@ -1,4 +1,11 @@
-import React, { type JSX, useEffect, useMemo, useRef, useState } from 'react';
+import React, {
+  type JSX,
+  useCallback,
+  useEffect,
+  useMemo,
+  useRef,
+  useState,
+} from 'react';
 import dynamic from 'next/dynamic';
 import type { IPagePopulatedToShowRevision } from '@growi/core';
 import { isUsersHomepage } from '@growi/core/dist/utils/page-path-utils';
@@ -190,7 +197,7 @@ export const PageView = (props: Props): JSX.Element => {
       </>
     ) : null;
 
-  const Contents = () => {
+  const Contents = useCallback(() => {
     if (isNotFound || page?.revision == null) {
       return <NotFoundPage path={pagePath} />;
     }
@@ -225,7 +232,16 @@ export const PageView = (props: Props): JSX.Element => {
         </div>
       </>
     );
-  };
+  }, [
+    isNotFound,
+    page?.revision,
+    page?._id,
+    rendererConfig,
+    pagePath,
+    viewOptions,
+    isSlide,
+    isIdenticalPathPage,
+  ]);
 
   return (
     <PageViewLayout

+ 13 - 3
apps/app/src/components/ShareLinkPageView/ShareLinkPageView.tsx

@@ -1,4 +1,4 @@
-import { type JSX, useMemo } from 'react';
+import { type JSX, useCallback, useMemo } from 'react';
 import dynamic from 'next/dynamic';
 import type { IPagePopulatedToShowRevision } from '@growi/core';
 import { useSlidesByFrontmatter } from '@growi/presentation/dist/services';
@@ -90,7 +90,7 @@ export const ShareLinkPageView = (props: Props): JSX.Element => {
 
   const footerContents = !isNotFound ? <PageContentFooter page={page} /> : null;
 
-  const Contents = () => {
+  const Contents = useCallback(() => {
     if (isNotFound || page.revision == null) {
       return <></>;
     }
@@ -117,7 +117,17 @@ export const ShareLinkPageView = (props: Props): JSX.Element => {
     ) : (
       <RevisionRenderer rendererOptions={rendererOptions} markdown={markdown} />
     );
-  };
+  }, [
+    isExpired,
+    isSlide,
+    pagePath,
+    viewOptions,
+    page?.revision?.body,
+    rendererConfig,
+    page?.revision,
+    isNotFound,
+    isSlide?.marp,
+  ]);
 
   return (
     <PageViewLayout