ソースを参照

migrate logger for packages/remark-lsx

Yuki Takei 1 週間 前
コミット
76b93ab1c0

+ 1 - 1
.kiro/specs/migrate-logger-to-pino/tasks.md

@@ -84,7 +84,7 @@
   - Run `pnpm --filter @growi/remark-attachment-refs lint:typecheck` and confirm the TS2769 error is gone
   - _Requirements: 10.1_
 
-- [ ] 5.5 Migrate packages/remark-lsx server routes to use @growi/logger
+- [x] 5.5 Migrate packages/remark-lsx server routes to use @growi/logger
   - Add `@growi/logger` to packages/remark-lsx dependencies
   - Create `src/utils/logger/index.ts` following the same pattern as remark-attachment-refs (import from `@growi/logger`, call `initializeLoggerFactory`, re-export `loggerFactory`)
   - Replace `console.error` calls in `src/server/routes/list-pages/index.ts` (lines 89, 145-148) with proper logger calls using `loggerFactory('growi:remark-lsx:routes:list-pages')`

+ 1 - 0
packages/remark-lsx/package.json

@@ -32,6 +32,7 @@
   "// comments for dependencies": {},
   "dependencies": {
     "@growi/core": "workspace:^",
+    "@growi/logger": "workspace:^",
     "@growi/remark-growi-directive": "workspace:^",
     "@growi/ui": "workspace:^",
     "express": "^4.20.0",

+ 7 - 6
packages/remark-lsx/src/server/routes/list-pages/index.ts

@@ -1,6 +1,7 @@
 import type { IUser } from '@growi/core';
 import { OptionParser } from '@growi/core/dist/remark-plugins';
 import { pathUtils } from '@growi/core/dist/utils';
+import { loggerFactory } from '@growi/logger';
 import type { Request, Response } from 'express';
 import createError, { isHttpError } from 'http-errors';
 
@@ -11,6 +12,8 @@ import { addSortCondition } from './add-sort-condition';
 import { generateBaseQuery, type PageQuery } from './generate-base-query';
 import { getToppageViewersCount } from './get-toppage-viewers-count';
 
+const logger = loggerFactory('growi:remark-lsx:routes:list-pages');
+
 const { addTrailingSlash, removeTrailingSlash } = pathUtils;
 
 /**
@@ -85,8 +88,7 @@ export const listPages = ({
     try {
       toppageViewersCount = await getToppageViewersCount();
     } catch (error) {
-      // biome-ignore lint/suspicious/noConsole: Allow to use console.error here
-      console.error('Error occurred in getToppageViewersCount:', error);
+      logger.error({ error }, 'Error occurred in getToppageViewersCount');
       return res.status(500).send('An internal server error occurred.');
     }
 
@@ -141,10 +143,9 @@ export const listPages = ({
       };
       return res.status(200).send(responseData);
     } catch (error) {
-      // biome-ignore lint/suspicious/noConsole: Allow to use console.error here
-      console.error(
-        'Error occurred while processing listPages request:',
-        error,
+      logger.error(
+        { error },
+        'Error occurred while processing listPages request',
       );
       if (isHttpError(error)) {
         return res.status(error.status).send(error.message);

+ 3 - 0
pnpm-lock.yaml

@@ -1745,6 +1745,9 @@ importers:
       '@growi/core':
         specifier: workspace:^
         version: link:../core
+      '@growi/logger':
+        specifier: workspace:^
+        version: link:../logger
       '@growi/remark-growi-directive':
         specifier: workspace:^
         version: link:../remark-growi-directive