Просмотр исходного кода

refactor: remove clearPages function and related references from useSelectedPages hook

Shun Miyazawa 8 месяцев назад
Родитель
Сommit
7690805c2d

+ 2 - 3
apps/app/src/features/openai/client/components/AiAssistant/AiAssistantManagementModal/AiAssistantManagementKeywordSearch.tsx

@@ -45,7 +45,7 @@ export const AiAssistantKeywordSearch = (props: Props): JSX.Element => {
 
   const [selectedSearchKeywords, setSelectedSearchKeywords] = useState<Array<SelectedSearchKeyword>>([]);
   const {
-    selectedPages, addPage, removePage, clearPages,
+    selectedPages, addPage, removePage,
   } = useSelectedPages(baseSelectedPages);
 
   const joinedSelectedSearchKeywords = useMemo(() => {
@@ -133,8 +133,7 @@ export const AiAssistantKeywordSearch = (props: Props): JSX.Element => {
   const nextButtonClickHandler = useCallback(() => {
     updateBaseSelectedPages(Array.from(selectedPages.values()));
     changePageMode(isNewAiAssistant ? AiAssistantManagementModalPageMode.HOME : AiAssistantManagementModalPageMode.PAGES);
-    clearPages();
-  }, [changePageMode, clearPages, isNewAiAssistant, selectedPages, updateBaseSelectedPages]);
+  }, [changePageMode, isNewAiAssistant, selectedPages, updateBaseSelectedPages]);
 
   return (
     <div className={moduleClass}>

+ 2 - 3
apps/app/src/features/openai/client/components/AiAssistant/AiAssistantManagementModal/AiAssistantManagementPageTreeSelection.tsx

@@ -93,7 +93,7 @@ export const AiAssistantManagementPageTreeSelection = (props: Props): JSX.Elemen
   const isNewAiAssistant = aiAssistantManagementModalData?.aiAssistantData == null;
 
   const {
-    selectedPages, addPage, removePage, clearPages,
+    selectedPages, addPage, removePage,
   } = useSelectedPages(baseSelectedPages);
 
   // SelectedPages will include subordinate pages by default
@@ -114,8 +114,7 @@ export const AiAssistantManagementPageTreeSelection = (props: Props): JSX.Elemen
   const nextButtonClickHandler = useCallback(() => {
     updateBaseSelectedPages(Array.from(selectedPages.values()));
     changePageMode(isNewAiAssistant ? AiAssistantManagementModalPageMode.HOME : AiAssistantManagementModalPageMode.PAGES);
-    clearPages();
-  }, [changePageMode, clearPages, isNewAiAssistant, selectedPages, updateBaseSelectedPages]);
+  }, [changePageMode, isNewAiAssistant, selectedPages, updateBaseSelectedPages]);
 
   return (
     <div className={moduleClass}>

+ 0 - 6
apps/app/src/features/openai/client/services/use-selected-pages.tsx

@@ -8,7 +8,6 @@ type UseSelectedPages = {
   selectedPages: Map<string, SelectedPage>,
   addPage: (page: SelectedPage) => void,
   removePage: (page: SelectedPage) => void,
-  clearPages: () => void,
 }
 
 export const useSelectedPages = (initialPages?: SelectedPage[]): UseSelectedPages => {
@@ -48,14 +47,9 @@ export const useSelectedPages = (initialPages?: SelectedPage[]): UseSelectedPage
     });
   }, []);
 
-  const clearPages = useCallback(() => {
-    setSelectedPages(new Map());
-  }, []);
-
   return {
     selectedPages,
     addPage,
     removePage,
-    clearPages,
   };
 };