Parcourir la source

add daependency arrays

Shun Miyazawa il y a 2 ans
Parent
commit
759cd04de7
1 fichiers modifiés avec 2 ajouts et 2 suppressions
  1. 2 2
      apps/app/src/components/PageHeader/PagePathHeader.tsx

+ 2 - 2
apps/app/src/components/PageHeader/PagePathHeader.tsx

@@ -66,7 +66,7 @@ export const PagePathHeader: FC<Props> = (props) => {
       setEditedPagePath(currentPagePath);
       setEditedPagePath(currentPagePath);
       setRenameInputShown(true);
       setRenameInputShown(true);
     }
     }
-  }, [currentPagePath, editedPagePath, isRenameInputShown, pagePathRenameHandler]);
+  }, [currentPagePath, editedPagePath, isRenameInputShown, onRenameFailure, onRenameFinish, pagePathRenameHandler]);
 
 
   const isOpened = PageSelectModalData?.isOpened ?? false;
   const isOpened = PageSelectModalData?.isOpened ?? false;
   const isViewMode = editorMode === EditorMode.View;
   const isViewMode = editorMode === EditorMode.View;
@@ -97,7 +97,7 @@ export const PagePathHeader: FC<Props> = (props) => {
     return () => {
     return () => {
       document.removeEventListener('click', clickOutSideHandler);
       document.removeEventListener('click', clickOutSideHandler);
     };
     };
-  }, []);
+  }, [clickOutSideHandler]);
 
 
 
 
   return (
   return (