Просмотр исходного кода

remove unnecessary Number cast

Futa Arai 1 год назад
Родитель
Сommit
6e9b361108

+ 2 - 2
apps/app/src/server/models/obsolete-page.js

@@ -268,11 +268,11 @@ export const getPageSchema = (crowi) => {
 
     this.grant = grant || GRANT_PUBLIC;
 
-    if (Number(grant) === GRANT_OWNER) {
+    if (grant === GRANT_OWNER) {
       this.grantedUsers.push(user?._id ?? user);
     }
 
-    if (Number(grant) === GRANT_USER_GROUP) {
+    if (grant === GRANT_USER_GROUP) {
       this.grantedGroups = grantUserGroupIds;
     }
   };

+ 1 - 1
apps/app/src/server/service/page-grant.ts

@@ -276,7 +276,7 @@ class PageGrantService implements IPageGrantService {
     ).length === 0;
 
     if (!userBelongsToAllPreviousGrantedGroups) {
-      if (Number(grant) !== PageGrant.GRANT_USER_GROUP) {
+      if (grant !== PageGrant.GRANT_USER_GROUP) {
         return false;
       }
       const pageGrantIncludesUserRelatedGroup = hasIntersection(grantedGroups?.map(g => getIdForRef(g.item)) || [], userRelatedGroupIds);

+ 1 - 1
apps/app/src/server/service/page/index.ts

@@ -4182,7 +4182,7 @@ class PageService implements IPageService {
       : clonedPageData.grantedGroups;
 
     const grantedUserIds = clonedPageData.grantedUserIds || [user._id];
-    const shouldBeOnTree = Number(grant) !== PageGrant.GRANT_RESTRICTED;
+    const shouldBeOnTree = grant !== PageGrant.GRANT_RESTRICTED;
     const isChildrenExist = await Page.count({ path: new RegExp(`^${escapeStringRegexp(addTrailingSlash(clonedPageData.path))}`), parent: { $ne: null } });
 
     const isGrantChangeable = await this.pageGrantService.validateGrantChange(user, pageData.grantedGroups, grant, grantUserGroupIds);