Shun Miyazawa 3 лет назад
Родитель
Сommit
6dede35fe9

+ 1 - 0
packages/app/src/server/models/activity.ts

@@ -119,6 +119,7 @@ activitySchema.statics.createByParameters = async function(parameters): Promise<
   return activity;
 };
 
+// Check if you should update using ActivityService.shoudUpdateActivity
 activitySchema.statics.updateByParameters = async function(activityId: string, parameters): Promise<IActivity> {
   const activity = await this.findOneAndUpdate({ _id: activityId }, parameters, { new: true }) as unknown as IActivity;
 

+ 1 - 1
packages/app/src/server/service/activity.ts

@@ -33,12 +33,12 @@ class ActivityService {
       if (!shoudUpdate) {
         try {
           await Activity.deleteOne({ _id: activityId });
+          return;
         }
         catch (err) {
           logger.error('Delete activity failed', err);
           return;
         }
-        return;
       }
 
       let activity: IActivity;