|
|
@@ -3,19 +3,18 @@ import { serializeUserSecurely } from '@growi/core/dist/models/serializers';
|
|
|
import type { Response } from 'express';
|
|
|
import { mock } from 'vitest-mock-extended';
|
|
|
|
|
|
+import { SCOPE } from '~/interfaces/scope';
|
|
|
import type Crowi from '~/server/crowi';
|
|
|
import type UserEvent from '~/server/events/user';
|
|
|
import { AccessToken } from '~/server/models/access-token';
|
|
|
|
|
|
+import { parserForAccessToken } from './access-token';
|
|
|
import type { AccessTokenParserReq } from './interfaces';
|
|
|
|
|
|
-import { accessTokenParser } from '.';
|
|
|
-
|
|
|
-
|
|
|
vi.mock('@growi/core/dist/models/serializers', { spy: true });
|
|
|
|
|
|
|
|
|
-describe('access-token-parser middleware', () => {
|
|
|
+describe('access-token-parser middleware for access token with scopes', () => {
|
|
|
|
|
|
let User;
|
|
|
|
|
|
@@ -41,18 +40,13 @@ describe('access-token-parser middleware', () => {
|
|
|
const resMock = mock<Response>();
|
|
|
const nextMock = vi.fn();
|
|
|
|
|
|
- expect(reqMock.user).toBeUndefined();
|
|
|
+ await parserForAccessToken([])(reqMock, resMock, nextMock);
|
|
|
|
|
|
- // act
|
|
|
- await accessTokenParser(reqMock, resMock, nextMock);
|
|
|
-
|
|
|
- // assert
|
|
|
expect(reqMock.user).toBeUndefined();
|
|
|
- expect(serializeUserSecurely).not.toHaveBeenCalled();
|
|
|
expect(nextMock).toHaveBeenCalled();
|
|
|
});
|
|
|
|
|
|
- it('should call next if the given access token is invalid', async() => {
|
|
|
+ it('should not authenticate with no scopes', async() => {
|
|
|
// arrange
|
|
|
const reqMock = mock<AccessTokenParserReq>({
|
|
|
user: undefined,
|
|
|
@@ -62,17 +56,31 @@ describe('access-token-parser middleware', () => {
|
|
|
|
|
|
expect(reqMock.user).toBeUndefined();
|
|
|
|
|
|
+ // prepare a user
|
|
|
+ const targetUser = await User.create({
|
|
|
+ name: faker.person.fullName(),
|
|
|
+ username: faker.string.uuid(),
|
|
|
+ password: faker.internet.password(),
|
|
|
+ lang: 'en_US',
|
|
|
+ });
|
|
|
+
|
|
|
+ // generate token with read:user:info scope
|
|
|
+ const { token } = await AccessToken.generateToken(
|
|
|
+ targetUser._id,
|
|
|
+ new Date(Date.now() + 1000 * 60 * 60 * 24),
|
|
|
+ );
|
|
|
+
|
|
|
// act
|
|
|
- reqMock.query.access_token = 'invalidToken';
|
|
|
- await accessTokenParser(reqMock, resMock, nextMock);
|
|
|
+ reqMock.query.access_token = token;
|
|
|
+ await parserForAccessToken([])(reqMock, resMock, nextMock);
|
|
|
|
|
|
// assert
|
|
|
expect(reqMock.user).toBeUndefined();
|
|
|
expect(serializeUserSecurely).not.toHaveBeenCalled();
|
|
|
- expect(nextMock).toHaveBeenCalled();
|
|
|
+ expect(nextMock).not.toHaveBeenCalled();
|
|
|
});
|
|
|
|
|
|
- it('should set req.user with a valid api token in query', async() => {
|
|
|
+ it('should authenticate with specific scope', async() => {
|
|
|
// arrange
|
|
|
const reqMock = mock<AccessTokenParserReq>({
|
|
|
user: undefined,
|
|
|
@@ -82,18 +90,24 @@ describe('access-token-parser middleware', () => {
|
|
|
|
|
|
expect(reqMock.user).toBeUndefined();
|
|
|
|
|
|
- // prepare a user with an access token
|
|
|
+ // prepare a user
|
|
|
const targetUser = await User.create({
|
|
|
name: faker.person.fullName(),
|
|
|
username: faker.string.uuid(),
|
|
|
password: faker.internet.password(),
|
|
|
lang: 'en_US',
|
|
|
- apiToken: faker.internet.password(),
|
|
|
});
|
|
|
|
|
|
+ // generate token with read:user:info scope
|
|
|
+ const { token } = await AccessToken.generateToken(
|
|
|
+ targetUser._id,
|
|
|
+ new Date(Date.now() + 1000 * 60 * 60 * 24),
|
|
|
+ [SCOPE.READ.USER.INFO],
|
|
|
+ );
|
|
|
+
|
|
|
// act
|
|
|
- reqMock.query.access_token = targetUser.apiToken;
|
|
|
- await accessTokenParser(reqMock, resMock, nextMock);
|
|
|
+ reqMock.query.access_token = token;
|
|
|
+ await parserForAccessToken([SCOPE.READ.USER.INFO])(reqMock, resMock, nextMock);
|
|
|
|
|
|
// assert
|
|
|
expect(reqMock.user).toBeDefined();
|
|
|
@@ -102,7 +116,7 @@ describe('access-token-parser middleware', () => {
|
|
|
expect(nextMock).toHaveBeenCalled();
|
|
|
});
|
|
|
|
|
|
- it('should set req.user with a valid api token in body', async() => {
|
|
|
+ it('should reject with insufficient scopes', async() => {
|
|
|
// arrange
|
|
|
const reqMock = mock<AccessTokenParserReq>({
|
|
|
user: undefined,
|
|
|
@@ -112,48 +126,33 @@ describe('access-token-parser middleware', () => {
|
|
|
|
|
|
expect(reqMock.user).toBeUndefined();
|
|
|
|
|
|
- // prepare a user with an access token
|
|
|
+
|
|
|
+ // prepare a user
|
|
|
const targetUser = await User.create({
|
|
|
name: faker.person.fullName(),
|
|
|
username: faker.string.uuid(),
|
|
|
password: faker.internet.password(),
|
|
|
lang: 'en_US',
|
|
|
- apiToken: faker.internet.password(),
|
|
|
});
|
|
|
|
|
|
- // act
|
|
|
- reqMock.body.access_token = targetUser.apiToken;
|
|
|
- await accessTokenParser(reqMock, resMock, nextMock);
|
|
|
-
|
|
|
- // assert
|
|
|
- expect(reqMock.user).toBeDefined();
|
|
|
- expect(reqMock.user?._id).toStrictEqual(targetUser._id);
|
|
|
- expect(serializeUserSecurely).toHaveBeenCalledOnce();
|
|
|
- expect(nextMock).toHaveBeenCalled();
|
|
|
- });
|
|
|
-
|
|
|
-});
|
|
|
-
|
|
|
+ // generate token with read:user:info scope
|
|
|
+ const { token } = await AccessToken.generateToken(
|
|
|
+ targetUser._id,
|
|
|
+ new Date(Date.now() + 1000 * 60 * 60 * 24),
|
|
|
+ [SCOPE.READ.USER.INFO],
|
|
|
+ );
|
|
|
|
|
|
-describe('access-token-parser middleware for access token', () => {
|
|
|
-
|
|
|
- let User;
|
|
|
+ // act - try to access with write:user:info scope
|
|
|
+ reqMock.query.access_token = token;
|
|
|
+ await parserForAccessToken([SCOPE.WRITE.USER.INFO])(reqMock, resMock, nextMock);
|
|
|
|
|
|
- beforeAll(async() => {
|
|
|
- const crowiMock = mock<Crowi>({
|
|
|
- event: vi.fn().mockImplementation((eventName) => {
|
|
|
- if (eventName === 'user') {
|
|
|
- return mock<UserEvent>({
|
|
|
- on: vi.fn(),
|
|
|
- });
|
|
|
- }
|
|
|
- }),
|
|
|
- });
|
|
|
- const userModelFactory = (await import('../../models/user')).default;
|
|
|
- User = userModelFactory(crowiMock);
|
|
|
+ // // assert
|
|
|
+ expect(reqMock.user).toBeUndefined();
|
|
|
+ expect(serializeUserSecurely).not.toHaveBeenCalled();
|
|
|
+ expect(nextMock).not.toHaveBeenCalled();
|
|
|
});
|
|
|
|
|
|
- it('should set req.user with a valid access token in query', async() => {
|
|
|
+ it('should authenticate with write scope implying read scope', async() => {
|
|
|
// arrange
|
|
|
const reqMock = mock<AccessTokenParserReq>({
|
|
|
user: undefined,
|
|
|
@@ -163,7 +162,7 @@ describe('access-token-parser middleware for access token', () => {
|
|
|
|
|
|
expect(reqMock.user).toBeUndefined();
|
|
|
|
|
|
- // prepare a user with an access token
|
|
|
+ // prepare a user
|
|
|
const targetUser = await User.create({
|
|
|
name: faker.person.fullName(),
|
|
|
username: faker.string.uuid(),
|
|
|
@@ -171,10 +170,16 @@ describe('access-token-parser middleware for access token', () => {
|
|
|
lang: 'en_US',
|
|
|
});
|
|
|
|
|
|
- // act
|
|
|
- const { token } = await AccessToken.generateToken(targetUser._id, new Date(Date.now() + 1000 * 60 * 60 * 24), []);
|
|
|
+ // generate token with write:user:info scope
|
|
|
+ const { token } = await AccessToken.generateToken(
|
|
|
+ targetUser._id,
|
|
|
+ new Date(Date.now() + 1000 * 60 * 60 * 24),
|
|
|
+ [SCOPE.WRITE.USER.INFO],
|
|
|
+ );
|
|
|
+
|
|
|
+ // act - try to access with read:user:info scope
|
|
|
reqMock.query.access_token = token;
|
|
|
- await accessTokenParser(reqMock, resMock, nextMock);
|
|
|
+ await parserForAccessToken([SCOPE.READ.USER.INFO])(reqMock, resMock, nextMock);
|
|
|
|
|
|
// assert
|
|
|
expect(reqMock.user).toBeDefined();
|
|
|
@@ -183,7 +188,7 @@ describe('access-token-parser middleware for access token', () => {
|
|
|
expect(nextMock).toHaveBeenCalled();
|
|
|
});
|
|
|
|
|
|
- it('should set req.user with a valid access token in body', async() => {
|
|
|
+ it('should authenticate with wildcard scope', async() => {
|
|
|
// arrange
|
|
|
const reqMock = mock<AccessTokenParserReq>({
|
|
|
user: undefined,
|
|
|
@@ -191,9 +196,7 @@ describe('access-token-parser middleware for access token', () => {
|
|
|
const resMock = mock<Response>();
|
|
|
const nextMock = vi.fn();
|
|
|
|
|
|
- expect(reqMock.user).toBeUndefined();
|
|
|
-
|
|
|
- // prepare a user with an access token
|
|
|
+ // prepare a user
|
|
|
const targetUser = await User.create({
|
|
|
name: faker.person.fullName(),
|
|
|
username: faker.string.uuid(),
|
|
|
@@ -201,10 +204,16 @@ describe('access-token-parser middleware for access token', () => {
|
|
|
lang: 'en_US',
|
|
|
});
|
|
|
|
|
|
- // act
|
|
|
- const { token } = await AccessToken.generateToken(targetUser._id, new Date(Date.now() + 1000 * 60 * 60 * 24), []);
|
|
|
+ // generate token with read:user:* scope
|
|
|
+ const { token } = await AccessToken.generateToken(
|
|
|
+ targetUser._id,
|
|
|
+ new Date(Date.now() + 1000 * 60 * 60 * 24),
|
|
|
+ [SCOPE.READ.USER.ALL],
|
|
|
+ );
|
|
|
+
|
|
|
+ // act - try to access with read:user:info scope
|
|
|
reqMock.query.access_token = token;
|
|
|
- await accessTokenParser(reqMock, resMock, nextMock);
|
|
|
+ await parserForAccessToken([SCOPE.READ.USER.INFO, SCOPE.READ.USER.API.ACCESS_TOKEN])(reqMock, resMock, nextMock);
|
|
|
|
|
|
// assert
|
|
|
expect(reqMock.user).toBeDefined();
|