Sfoglia il codice sorgente

123395 move return into catch

soumaeda 3 anni fa
parent
commit
6a64a3651b
1 ha cambiato i file con 2 aggiunte e 4 eliminazioni
  1. 2 4
      apps/app/src/server/routes/apiv3/users.js

+ 2 - 4
apps/app/src/server/routes/apiv3/users.js

@@ -185,7 +185,6 @@ module.exports = (crowi) => {
   const sendEmailByUser = async(user) => {
     const { appService, mailService } = crowi;
     const appTitle = appService.getAppTitle();
-    const failedToSendNewPasswordEmail = { email: user.email, reason: '' };
 
     try {
       await mailService.send({
@@ -201,11 +200,10 @@ module.exports = (crowi) => {
       });
     }
     catch (err) {
+      const failedToSendNewPasswordEmail = { email: user.email, reason: err.message };
       logger.error(err);
-      failedToSendNewPasswordEmail.reason = err.message;
+      return { failedToSendNewPasswordEmail };
     }
-
-    return { failedToSendNewPasswordEmail };
   };
 
   /**