Просмотр исходного кода

no deletion even if you don't belong to a group

Shun Miyazawa 3 лет назад
Родитель
Сommit
56d36602f8
1 измененных файлов с 5 добавлено и 14 удалено
  1. 5 14
      packages/app/src/server/service/activity.ts

+ 5 - 14
packages/app/src/server/service/activity.ts

@@ -29,28 +29,19 @@ class ActivityService {
 
   initActivityEventListeners(): void {
     this.activityEvent.on('update', async(activityId: string, parameters, target?: IPage) => {
+      let activity: IActivity;
       const shoudUpdate = this.shoudUpdateActivity(parameters.action);
-      if (!shoudUpdate) {
+      if (shoudUpdate) {
         try {
-          await Activity.deleteOne({ _id: activityId });
-          return;
+          activity = await Activity.updateByParameters(activityId, parameters);
         }
         catch (err) {
-          logger.error('Delete activity failed', err);
+          logger.error('Update activity failed', err);
           return;
         }
-      }
 
-      let activity: IActivity;
-      try {
-        activity = await Activity.updateByParameters(activityId, parameters);
-      }
-      catch (err) {
-        logger.error('Update activity failed', err);
-        return;
+        this.activityEvent.emit('updated', activity, target);
       }
-
-      this.activityEvent.emit('updated', activity, target);
     });
   }