Yuki Takei 2 лет назад
Родитель
Сommit
5584e5566c

+ 2 - 6
apps/app/src/components/PageDuplicateModal.tsx

@@ -80,14 +80,10 @@ const PageDuplicateModal = (): JSX.Element => {
     }
   }, [isOpened, pageNameInput, subordinatedPages, checkExistPathsDebounce, page]);
 
-  /**
-   * change pageNameInput for PagePathAutoComplete
-   * @param {string} value
-   */
-  function ppacInputChangeHandler(value) {
+  const ppacInputChangeHandler = useCallback((value: string) => {
     setErrs(null);
     setPageNameInput(value);
-  }
+  }, []);
 
   /**
    * change pageNameInput

+ 2 - 2
apps/app/src/components/PageRenameModal.tsx

@@ -166,10 +166,10 @@ const PageRenameModal = (): JSX.Element => {
     }
   }, [isOpened, pageNameInput, subordinatedPages, checkExistPathsDebounce, page, checkIsUsersHomepageDebounce]);
 
-  function ppacInputChangeHandler(value) {
+  const ppacInputChangeHandler = useCallback((value: string) => {
     setErrs(null);
     setPageNameInput(value);
-  }
+  }, []);
 
   /**
    * change pageNameInput

+ 1 - 1
apps/app/src/components/PageStatusAlert.tsx

@@ -78,7 +78,7 @@ export const PageStatusAlert = (): JSX.Element => {
     {t('hackmd.this_page_has_draft')}
   </>,
       btn:
-  <button onClick={() => mutateEditorMode(EditorMode.HackMD)} className="btn btn-outline-white">
+  <button type="button" onClick={() => mutateEditorMode(EditorMode.HackMD)} className="btn btn-outline-white">
     <i className="fa fa-fw fa-file-text-o mr-1"></i>
     Open HackMD Editor
   </button>,

+ 1 - 0
apps/app/src/components/Sidebar/Bookmarks/BookmarkContents.tsx

@@ -41,6 +41,7 @@ export const BookmarkContents = (): JSX.Element => {
     <>
       <div className="col-8 mb-2 ">
         <button
+          type="button"
           className="btn btn-block btn-outline-secondary rounded-pill d-flex justify-content-start align-middle"
           onClick={onClickNewBookmarkFolder}
         >

+ 1 - 0
apps/app/src/components/UsersHomepageFooter.tsx

@@ -31,6 +31,7 @@ export const UsersHomepageFooter = (props: UsersHomepageFooterProps): JSX.Elemen
           {t('footer.bookmarks')}
           <span className="ml-auto pl-2 ">
             <button
+              type="button"
               className={`btn btn-sm grw-expand-compress-btn ${isExpanded ? 'active' : ''}`}
               onClick={() => setIsExpanded(!isExpanded)}
             >