Browse Source

add i18n and todo comment

yuto-oweseek 4 years ago
parent
commit
50515028e4

+ 1 - 0
packages/app/resource/locales/en_US/translation.json

@@ -137,6 +137,7 @@
   "Shareable link": "Shareable link",
   "The whitelist of registration permission E-mail address": "The whitelist of registration permission E-mail address",
   "Add tags for this page": "Add tags for this page",
+  "Check All tags": "check all tags",
   "You have no tag, You can set tags on pages": "You have no tag, You can set tags on pages",
   "Show latest": "Show latest",
   "Load latest": "Load latest",

+ 1 - 0
packages/app/resource/locales/ja_JP/translation.json

@@ -137,6 +137,7 @@
   "Shareable link": "このページの共有用URL",
   "The whitelist of registration permission E-mail address": "登録許可メールアドレスの<br>ホワイトリスト",
   "Add tags for this page": "タグを付ける",
+  "Check All tags": "全てのタグをチェックする",
   "You have no tag, You can set tags on pages": "使用中のタグがありません",
   "Show latest": "最新のページを表示",
   "Load latest": "最新版を読み込む",

+ 1 - 0
packages/app/resource/locales/zh_CN/translation.json

@@ -146,6 +146,7 @@
 	"Shareable link": "可分享链接",
 	"The whitelist of registration permission E-mail address": "注册许可电子邮件地址的白名单",
 	"Add tags for this page": "添加标签",
+  "Check All tags": "检查所有标签",
 	"You have no tag, You can set tags on pages": "你没有标签,可以在页面上设置标签",
 	"Show latest": "显示最新",
 	"Load latest": "家在最新",

+ 0 - 1
packages/app/src/components/Sidebar/SidebarNav.jsx

@@ -19,7 +19,6 @@ class SidebarNav extends React.Component {
 
   itemSelectedHandler = (contentsId) => {
     const { navigationContainer, onItemSelected } = this.props;
-    console.log(navigationContainer, ' in itemSelectedHandler:', onItemSelected);
     if (onItemSelected != null) {
       onItemSelected(contentsId);
     }

+ 12 - 3
packages/app/src/components/Sidebar/Tag.tsx

@@ -16,7 +16,14 @@ const Tag: FC<Props> = (props:Props) => {
     <>
       <div className="grw-sidebar-content-header p-3 d-flex">
         <h3 className="mb-0">{t('Tags')}</h3>
-        <button type="button" className="btn btn-sm ml-auto grw-btn-reload-rc" onClick={() => {}}>
+        <button
+          type="button"
+          className="btn btn-sm ml-auto grw-btn-reload-rc"
+          onClick={() => {
+            // TODO: consider how to reload tags
+            console.log('reload tag');
+          }}
+        >
           <i className="icon icon-reload"></i>
         </button>
       </div>
@@ -29,10 +36,12 @@ const Tag: FC<Props> = (props:Props) => {
             window.location.href = '/tags';
           }}
         >
-          check all tag
+          {t('Check All tags')}
         </button>
       </div>
-      <TagsList crowi={appContainer} />
+      <div className="grw-container-convertible mb-5 pb-5">
+        <TagsList crowi={appContainer} />
+      </div>
     </>
   );