Просмотр исходного кода

fix type errors of @growi/slack

Yuki Takei 2 лет назад
Родитель
Сommit
4a6f66ca1c

+ 3 - 0
packages/slack/package.json

@@ -50,6 +50,9 @@
   "dependencies": {
     "@slack/oauth": "^2.0.1",
     "@slack/web-api": "^6.2.4",
+    "@types/bunyan": "^1.8.10",
+    "@types/http-errors": "^2.0.3",
+    "@types/url-join": "^4.0.2",
     "axios": "^0.24.0",
     "browser-bunyan": "^1.6.3",
     "bunyan": "^1.8.15",

+ 1 - 1
packages/slack/src/utils/check-communicable.ts

@@ -86,7 +86,7 @@ export const getConnectionStatus = async(token:string): Promise<ConnectionStatus
     status.workspaceName = await retrieveWorkspaceName(client);
   }
   catch (err) {
-    status.error = err;
+    status.error = err as Error;
   }
 
   return status;

+ 1 - 4
packages/slack/tsconfig.json

@@ -8,10 +8,7 @@
     },
     "types": [
       "vitest/globals"
-    ],
-
-    /* TOOD: remove below flags for strict checking */
-    "noImplicitAny": false
+    ]
   },
   "include": [
     "src"

+ 20 - 0
yarn.lock

@@ -2658,6 +2658,9 @@
   dependencies:
     "@slack/oauth" "^2.0.1"
     "@slack/web-api" "^6.2.4"
+    "@types/bunyan" "^1.8.10"
+    "@types/http-errors" "^2.0.3"
+    "@types/url-join" "^4.0.2"
     axios "^0.24.0"
     browser-bunyan "^1.6.3"
     bunyan "^1.8.15"
@@ -3943,6 +3946,13 @@
     "@types/express" "*"
     "@types/node" "*"
 
+"@types/bunyan@^1.8.10":
+  version "1.8.10"
+  resolved "https://registry.yarnpkg.com/@types/bunyan/-/bunyan-1.8.10.tgz#60f2d297c3d29fd3b85c54f28a48b99d61686fe0"
+  integrity sha512-A82U/3EAdWX89f+dfysGiRvbeoLuRLV3i6SLg3HuNK4Yf+dHOqdbxT70vQUwvD3DOr2Dvpcv9dRX4ipTf0LpEg==
+  dependencies:
+    "@types/node" "*"
+
 "@types/cache-manager@^3.4.0":
   version "3.4.0"
   resolved "https://registry.yarnpkg.com/@types/cache-manager/-/cache-manager-3.4.0.tgz#414136ea3807a8cd071b8f20370c5df5dbffd382"
@@ -4078,6 +4088,11 @@
     "@types/react" "*"
     hoist-non-react-statics "^3.3.0"
 
+"@types/http-errors@^2.0.3":
+  version "2.0.3"
+  resolved "https://registry.yarnpkg.com/@types/http-errors/-/http-errors-2.0.3.tgz#c54e61f79b3947d040f150abd58f71efb422ff62"
+  integrity sha512-pP0P/9BnCj1OVvQR2lF41EkDG/lWWnDyA203b/4Fmi2eTyORnBtcDoKDwjWQthELrBvWkMOrvSOnZ8OVlW6tXA==
+
 "@types/is-stream@^1.1.0":
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/@types/is-stream/-/is-stream-1.1.0.tgz#b84d7bb207a210f2af9bed431dc0fbe9c4143be1"
@@ -4347,6 +4362,11 @@
   resolved "https://registry.yarnpkg.com/@types/unist/-/unist-2.0.3.tgz#9c088679876f374eb5983f150d4787aa6fb32d7e"
   integrity sha512-FvUupuM3rlRsRtCN+fDudtmytGO6iHJuuRKS1Ss0pG5z8oX0diNEw94UEL7hgDbpN94rgaK5R7sWm6RrSkZuAQ==
 
+"@types/url-join@^4.0.2":
+  version "4.0.2"
+  resolved "https://registry.yarnpkg.com/@types/url-join/-/url-join-4.0.2.tgz#e8774924c7f492626ee3309baf6697f80e1414df"
+  integrity sha512-uv54MkAtQ4B5Qm20LmMN7tAdczqRenu1K6Sf7PHCygqylVJlRwjpUE5OGofqxdXGH3QJUu+qvDZzPadz5EOjxA==
+
 "@types/warning@^3.0.0":
   version "3.0.0"
   resolved "https://registry.yarnpkg.com/@types/warning/-/warning-3.0.0.tgz#0d2501268ad8f9962b740d387c4654f5f8e23e52"