Просмотр исходного кода

move setState end of useEffect and rename state

keigo-h 3 лет назад
Родитель
Сommit
45d79a86f0
1 измененных файлов с 4 добавлено и 4 удалено
  1. 4 4
      packages/app/src/client/services/ShowPageAccessoriesModal.tsx

+ 4 - 4
packages/app/src/client/services/ShowPageAccessoriesModal.tsx

@@ -12,22 +12,22 @@ const queryCompareFormat = new RegExp(/([a-z0-9]){24}...([a-z0-9]){24}/);
 
 const ShowPageAccessoriesModal = (): JSX.Element => {
   const { data: status, open: openPageAccessories } = usePageAccessoriesModal();
-  const [isOpenDone, setIsOpenDone] = useState(false);
+  const [isArleadyMounted, setIsArleadyMounted] = useState(false);
   useEffect(() => {
     const pageIdParams = getURLQueryParamValue('compare');
     if (status == null || status.isOpened === true) {
       return;
     }
-    if (isOpenDone === true) {
+    if (isArleadyMounted === true) {
       return;
     }
     if (pageIdParams != null) {
       if (queryCompareFormat.test(pageIdParams)) {
         openPageAccessories(PageAccessoriesModalContents.PageHistory);
-        setIsOpenDone(true);
       }
     }
-  }, [openPageAccessories, status, isOpenDone]);
+    setIsArleadyMounted(true);
+  }, [openPageAccessories, status, isArleadyMounted]);
   return <></>;
 };