Преглед изворни кода

validate grant change for v4

Futa Arai пре 2 година
родитељ
комит
430d1b1716
2 измењених фајлова са 2 додато и 0 уклоњено
  1. 1 0
      apps/app/src/server/service/page-grant.ts
  2. 1 0
      apps/app/src/server/service/page.ts

+ 1 - 0
apps/app/src/server/service/page-grant.ts

@@ -449,6 +449,7 @@ class PageGrantService {
    * @param includeNotMigratedPages Whether or not to use unmigrated pages for validation
    * @param includeNotMigratedPages Whether or not to use unmigrated pages for validation
    * @param previousGrantedGroupIds
    * @param previousGrantedGroupIds
    *   Previously granted groups of the page. Specific validation is required when previous grant is multiple group grant.
    *   Previously granted groups of the page. Specific validation is required when previous grant is multiple group grant.
+   *   Apply when page grant change needs to be validated.
    *   see: https://dev.growi.org/656745fa52eafe1cf1879508#%E3%83%9A%E3%83%BC%E3%82%B8%E3%81%AE-grant-%E3%81%AE%E6%9B%B4%E6%96%B0
    *   see: https://dev.growi.org/656745fa52eafe1cf1879508#%E3%83%9A%E3%83%BC%E3%82%B8%E3%81%AE-grant-%E3%81%AE%E6%9B%B4%E6%96%B0
    * @returns Promise<boolean>
    * @returns Promise<boolean>
    */
    */

+ 1 - 0
apps/app/src/server/service/page.ts

@@ -4176,6 +4176,7 @@ class PageService {
     const isSyncRevisionToHackmd = options.isSyncRevisionToHackmd;
     const isSyncRevisionToHackmd = options.isSyncRevisionToHackmd;
 
 
     // TODO 136137: validate multiple group grant before save using pageData and options
     // TODO 136137: validate multiple group grant before save using pageData and options
+    await this.pageGrantService.validateGrantChange(user, pageData.grantedGroups, grant, grantUserGroupIds);
 
 
     await this.validateAppliedScope(user, grant, grantUserGroupIds);
     await this.validateAppliedScope(user, grant, grantUserGroupIds);
     pageData.applyScope(user, grant, grantUserGroupIds);
     pageData.applyScope(user, grant, grantUserGroupIds);